On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote:
We have too much logic to simply check that bitmaps are of the same
size. Let's just define that hbitmap_merge() and
bdrv_dirty_bitmap_merge_internal() require their argument bitmaps be of
same size, this simplifies things.
Let's look
On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote:
We don't need extra bitmap. All we need is to backup the original
bitmap when we do first merge. So, drop extra temporary bitmap and work
directly with target and backup.
Note that block_dirty_bitmap_merge() semantics changed: on failure
On 2/15/22 20:53, Vladimir Sementsov-Ogievskiy wrote:
Reviewed-by: Nikita Lapshin
At the end we ignore failure of bdrv_merge_dirty_bitmap() and report
success. And still set errp. That's wrong.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/monitor/bitmap-qmp-cmds.c | 5 -
1
On 12/22/21 20:40, Vladimir Sementsov-Ogievskiy wrote:
Add function to wait for all intersecting requests.
To be used in the further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/reqlist.h | 8
block/reqlist.c | 8
2 files changed, 16
On 12/22/21 20:40, Vladimir Sementsov-Ogievskiy wrote:
Add a convenient function similar with bdrv_block_status() to get
status of dirty bitmap.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 2 ++
include/qemu/hbitmap.h | 11 +++
On 12/24/21 18:35, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
v2: rebase on master, fix iostest 283
Block jobs usually operate with several block nodes, and better to
handle them symmetrically, than use one from s->common.blk and one from
s->target (or something like this). Moreover,
On 12/13/21 18:32, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Nikita Lapshin
On 12/13/21 18:32, Vladimir Sementsov-Ogievskiy wrote:
For QemuIoInteractive use new wrapper as well, which allows relying on
default format.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Nikita Lapshin
On 12/13/21 18:32, Vladimir Sementsov-Ogievskiy wrote:
Split qemu_tool_popen() from qemu_tool_pipe_and_status() to be used
separately.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Nikita Lapshin
On 12/13/21 18:32, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Nikita Lapshin
10 matches
Mail list logo