On 11/25/2021 9:53 PM, Hanna Reitz wrote:
> Hi,
>
> Peng Liang has reported an issue regarding migration of raw images here:
> https://lists.nongnu.org/archive/html/qemu-block/2021-11/msg00673.html
>
> It turns out that after migrating, all permissions are shared when the
5f7772c4d0cf32f4e779fcd5a69ae4dae24aeebf
>("block-backend: Defer shared_perm tightening migration
>completion")
> Reported-by: Peng Liang
> Signed-off-by: Hanna Reitz
> ---
> block/block-backend.c | 11 +++
> 1 file changed, 11 insertions(+)
>
Thanks for your patch!
Tested-by: Peng Liang
Hi folks,
When we test migration with raw-format disk, we found that the QEMU
process in the dst will lose the write lock after migration. However,
the QEMU process in the dst will still hold the write lock for
qcow2-format disk.
After reading some block layer's code, I found that the first
On 9/23/2020 10:50 PM, John Snow wrote:
> On 8/26/20 9:19 AM, Peng Liang wrote:
>> We found an issue when doing block-commit with iothreads, which tries to
>> dereference a NULL pointer.
>>
>
> I'm clearing out my patch backlog. I am a bit out of the loop on block
Hi,
I encountered the problem months ago too. Could we move the creation of
the block job (block_job_create) before appending the new bs to
mirror_top_bs (bdrv_append) as I wrote in [*]? I found that after
bdrv_append, qemu will use mirror_top_bs to do write. And when writing,
qemu will use
1e8,
envp=0x7ffe4cf8f4e0) at ../softmmu/main.c:50
Reported-by: Euler Robot
Signed-off-by: Peng Liang
---
block/nbd.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/block/nbd.c b/block/nbd.c
index 42536702b6f9..b22a9ecbbcd0 100644
--- a/block/nbd.c
+++ b/block/nb
| (s->job is not NULL until 3!)
3. bs_opaque->job = s;|
Just moving step 2 & 3 before 1 can avoid this.
Reported-by: Euler Robot
Signed-off-by: Peng Liang
---
block/mirror.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
