Re: [PATCH 1/8] m25p80: Improve error when the backend file size does not match the device

2023-02-15 Thread Peter Delevoryas
> This is confusing for the user. > > Use blk_check_size_and_read_all() instead of blk_pread() to improve > the reported error. > > Reviewed-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Peter Delevoryas > Reviewed-by: Alistair Francis > M

Re: [PATCH v2] m25p80: Improve error when the backend file size does not match the device

2022-11-15 Thread Peter Delevoryas
> > hw/block/m25p80.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Philippe Mathieu-Daudé > Thanks Cedric! Reviewed-by: Peter Delevoryas

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-04 Thread Peter Delevoryas
On Thu, Aug 04, 2022 at 11:07:10AM -0700, Dan Zhang wrote: > On Wed, Aug 3, 2022 at 10:30 AM Peter Delevoryas wrote: > > > > On Wed, Aug 03, 2022 at 10:52:23AM +0200, Cédric Le Goater wrote: > > > On 8/3/22 04:32, Iris Chen wrote: > > > > From: Iris Chen >

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2022-08-03 Thread Peter Delevoryas
On Wed, Aug 03, 2022 at 10:52:23AM +0200, Cédric Le Goater wrote: > On 8/3/22 04:32, Iris Chen wrote: > > From: Iris Chen > > A commit log telling us about this new device would be good to have. > > > > Signed-off-by: Iris Chen > > --- > > configs/devices/arm-softmmu/default.mak | 1 + > >

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-08-01 Thread Peter Delevoryas
On Mon, Aug 01, 2022 at 11:49:09AM +0930, Andrew Jeffery wrote: > > > On Sun, 31 Jul 2022, at 06:48, Cédric Le Goater wrote: > > On 7/29/22 19:30, Peter Delevoryas wrote: > >> Certainly we'd like to use IRQ's instead, but she ran into correctness > >> p

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-30 Thread Peter Delevoryas
On Sat, Jul 30, 2022 at 11:18:33PM +0200, Cédric Le Goater wrote: > On 7/29/22 19:30, Peter Delevoryas wrote: > > On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > > > Hello Iris, > > > > > > On 7/29/22 01:23, Iris Chen wrote: > > >

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-29 Thread Peter Delevoryas
On Fri, Jul 29, 2022 at 03:25:55PM +0200, Cédric Le Goater wrote: > Hello Iris, > > On 7/29/22 01:23, Iris Chen wrote: > > Hey everyone, > > > > I have been working on a project to add support for SPI-based TPMs in QEMU. > > Currently, most of our vboot platforms using a SPI-based TPM use the

Re: [RFC 0/3] Add Generic SPI GPIO model

2022-07-28 Thread Peter Delevoryas
On Thu, Jul 28, 2022 at 04:23:19PM -0700, Iris Chen wrote: > Hey everyone, > > I have been working on a project to add support for SPI-based TPMs in QEMU. > Currently, most of our vboot platforms using a SPI-based TPM use the Linux > SPI-GPIO driver to "bit-bang" the SPI protocol. This is

Re: [PATCH v2 1/2] hw: m25p80: add WP# pin and SRWD bit for write protection

2022-06-09 Thread Peter Delevoryas
> On Jun 9, 2022, at 12:22 PM, Francisco Iglesias > wrote: > > Hi Iris, > > Looks good some, a couple of comments below. > > On [2022 Jun 08] Wed 20:13:19, Iris Chen wrote: >> From: Iris Chen >> >> Signed-off-by: Iris Chen >> --- >> Addressed all comments from V1. The biggest change:

Re: [PATCH v2] hw: m25p80: allow write_enable latch get/set

2022-05-12 Thread Peter Delevoryas
> On May 11, 2022, at 10:25 PM, Cédric Le Goater wrote: > > Hello Iris, > > [ Fixing Thomas email ] > > On 5/12/22 02:54, Iris Chen via wrote: >> The write_enable latch property is not currently exposed. >> This commit makes it a modifiable property using get/set methods. >> Signed-off-by:

Re: [PATCH v2] hw: m25p80: allow write_enable latch get/set

2022-05-12 Thread Peter Delevoryas
> On May 11, 2022, at 6:38 PM, Peter Delevoryas wrote: > > > >> On May 11, 2022, at 5:54 PM, Iris Chen wrote: >> >> The write_enable latch property is not currently exposed. >> This commit makes it a modifiable property using get/set methods. >>

Re: [PATCH v2] hw: m25p80: allow write_enable latch get/set

2022-05-12 Thread Peter Delevoryas
> On May 11, 2022, at 5:54 PM, Iris Chen wrote: > > The write_enable latch property is not currently exposed. > This commit makes it a modifiable property using get/set methods. > > Signed-off-by: Iris Chen > --- > Ran ./scripts/checkpatch.pl on the patch and added a description. Fixed >