Re: [PATCH 03/11] MAINTAINERS: add a section for policy documents

2023-03-30 Thread Warner Losh
-) > > Who's with me? > > Signed-off-by: Alex Bennée > Cc: Thomas Huth > Cc: Daniel P. Berrangé > Cc: Markus Armbruster > Cc: Kashyap Chamarthy > Cc: Paolo Bonzini > Cc: Peter Maydell > Cc: Philippe Mathieu-Daudé > Cc: Bernhard Beschow > Reviewed-by: Warne

Re: [PATCH v4 03/19] scripts/clean-includes: Skip symbolic links

2023-01-27 Thread Warner Losh
On Fri, Jan 27, 2023 at 3:47 PM Eric Blake wrote: > On Thu, Jan 19, 2023 at 07:59:43AM +0100, Markus Armbruster wrote: > > When a symbolic link points to a file that needs cleaning, the script > > replaces the link with a cleaned regular file. Not wanted; skip them. > > > > We have a few

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Warner Losh
On Thu, Jan 19, 2023 at 9:42 AM Markus Armbruster wrote: > Warner Losh writes: > > > On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster > > wrote: > > > >> Clean up includes so that osdep.h is included first and headers > >> which it implies are no

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Warner Losh
On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- > bsd-user/bsd-proc.h

Re: [PATCH v2 08/15] scripts/qapi: add required system includes to visitor

2022-07-12 Thread Warner Losh
gt; scripts/qapi/visit.py | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Warner Losh > diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py > index 1ff464c0360f..4aba5ddd8af4 100644 > --- a/scripts/qapi/visit.py > +++ b/scripts/qapi/visit.py > @@ -342,

Re: [PATCH v2 04/15] error-report: introduce overridable error_is_detailed()

2022-07-12 Thread Warner Losh
h | 2 ++ > softmmu/vl.c| 5 + > stubs/error-is-detailed.c | 7 +++ > util/error-report.c | 3 +-- > stubs/meson.build | 1 + > 5 files changed, 16 insertions(+), 2 deletions(-) > create mode 100644 stubs/error-is-detailed.c > Reviewed-b

Re: [PATCH v2 12/15] qemu-common: move glib-compat.h

2022-07-12 Thread Warner Losh
name {include => subprojects/qemu-common/include}/glib-compat.h (97%) > Reviewed-by: Warner Losh > > diff --git a/include/glib-compat.h > b/subprojects/qemu-common/include/glib-compat.h > similarity index 97% > rename from include/glib-compat.h > rename to subprojects/qem

Re: [PATCH v2 10/15] qemu-common: introduce a common subproject

2022-07-12 Thread Warner Losh
On Tue, Jul 12, 2022 at 3:36 AM wrote: > From: Marc-André Lureau > > Add a new meson subproject to provide common code and scripts for QEMU > and tools. Initially, it will offer QAPI/QMP code generation and > common utilities. > > libvhost-user & libvduse will make use of the subproject to

Re: [PATCH 5/9] error-report: introduce ErrorReportDetailedFunc

2022-06-16 Thread Warner Losh
si/qemu-pr-helper.c| 2 +- > softmmu/vl.c | 7 ++- > storage-daemon/qemu-storage-daemon.c | 7 ++- > util/error-report.c | 8 +--- > 10 files changed, 26 insertions(+), 12 deletions(-) > Reviewed-by: Warner Losh W

Re: [PATCH 19/41] compiler.h: replace QEMU_NORETURN with G_NORETURN

2022-04-20 Thread Warner Losh
n qemu codebase usage). > > Signed-off-by: Marc-André Lureau > Reviewed-by: Warner Losh Most of this looks mechanical, but I only looked closely at the bsd-user changes. > --- > accel/tcg/internal.h | 3 +-- > include/exec/exec-all.h | 20 +

Re: [PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

2022-04-20 Thread Warner Losh
On Wed, Apr 20, 2022 at 7:26 AM wrote: > From: Marc-André Lureau > > Suggested-by: Peter Maydell > Signed-off-by: Marc-André Lureau > Reviewed-by: Warner Losh > --- > include/{qemu-common.h => qemu/copyright.h} | 0 > bsd-user/main.c

Re: [PATCH v4 4/8] tests: Refresh lcitool submodule

2022-01-21 Thread Warner Losh
On Fri, Jan 21, 2022 at 4:47 AM Daniel P. Berrangé wrote: > On Fri, Jan 21, 2022 at 12:40:48PM +0100, Thomas Huth wrote: > > On 21/01/2022 11.36, Philippe Mathieu-Daudé wrote: > > > Refresh lcitool submodule and the generated files by running: > > > > > >$ make lcitool-refresh > > > > > >

Re: [RFC 0/2] tls: add macros for coroutine-safe TLS variables

2021-10-25 Thread Warner Losh
On Mon, Oct 25, 2021 at 10:18 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 10/25/21 7:07 AM, Stefan Hajnoczi wrote: > > This is a preview of how we can solve the coroutines TLS problem. > Coroutines > > re-entered from another thread sometimes see stale TLS values. This >

Re: [RFC PATCH 9/9] hw/sd: Allow card size not power of 2 again

2021-06-24 Thread Warner Losh
> On Jun 24, 2021, at 4:56 AM, Peter Maydell wrote: > > On Thu, 24 Jun 2021 at 11:27, Tom Yan wrote: >> I really think we should get (/ have gotten) things clear first. What >> exactly is the bug we have been talking about here? I mean like, where >> does it occur and what's the nature of it.

Re: [PATCH 07/23] hw/block/nvme: Use definition to avoid dynamic stack allocation

2021-05-05 Thread Warner Losh
On Wed, May 5, 2021, 5:10 PM Eric Blake wrote: > On 5/5/21 5:07 PM, Philippe Mathieu-Daudé wrote: > > +Eric > > > > On 5/5/21 11:22 PM, Keith Busch wrote: > >> On Wed, May 05, 2021 at 11:10:31PM +0200, Philippe Mathieu-Daudé wrote: > >>> The compiler isn't clever enough to figure

Re: [PATCH 2/3] hw/ide: Add Kconfig dependency MICRODRIVE -> PCMCIA

2021-04-24 Thread Warner Losh
On Sat, Apr 24, 2021 at 4:24 PM Philippe Mathieu-Daudé wrote: > The Microdrive Compact Flash can be plugged on a PCMCIA bus. > Express the dependency using the 'depends on' Kconfig expression. > Reviewed-by: Warner Losh > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH 1/3] hw/arm/pxa2xx: Declare PCMCIA bus with Kconfig

2021-04-24 Thread Warner Losh
e PCMCIA bus since I think it's more confusing than helpful... Reviewed-by: Warner Losh > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 8c37cf00da7..b887f6a5

Re: [RFC PATCH 3/3] hw/block/nvme: add nvme_inject_state HMP command

2021-02-10 Thread Warner Losh
On Wed, Feb 10, 2021, 9:26 PM Keith Busch wrote: > On Thu, Feb 11, 2021 at 12:38:48PM +0900, Minwoo Im wrote: > > On 21-02-11 12:00:11, Keith Busch wrote: > > > But I would prefer to see advanced retry tied to real errors that can > be > > > retried, like if we got an EBUSY or EAGAIN errno or

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-26 Thread Warner Losh
On Mon, Jan 25, 2021 at 6:33 PM Joelle van Dyne wrote: > Some BSD platforms do not have this header. > > Signed-off-by: Joelle van Dyne > --- > meson.build| 1 + > block.c| 2 +- > block/file-posix.c | 2 +- > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-26 Thread Warner Losh
avoid top-posting, and to > instead reply inline to make the conversation easier to follow. > > > > > -j > > > > On Mon, Jan 25, 2021 at 8:35 PM Warner Losh wrote: > >> > >> > >> > >> On Mon, Jan 25, 2021 at 6:33 PM

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-26 Thread Warner Losh
the systems that it exists on. > -j > > On Mon, Jan 25, 2021 at 8:35 PM Warner Losh wrote: > > > > > > > > On Mon, Jan 25, 2021 at 6:33 PM Joelle van Dyne wrote: > >> > >> Some BSD platforms do not have this header. > >> > >> Sign