On Thu, Mar 28, 2024 at 6:23 PM <marcandre.lur...@redhat.com> wrote:
> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> ../migration/dirtyrate.c:186:5: error: ‘records’ may be used uninitialized
> [-Werror=maybe-uninitialized]
> ../migration/dirtyrate.c:168:12: error: ‘gen_id’ may be used uninitialized
> [-Werror=maybe-uninitialized]
> ../migration/migration.c:2273:5: error: ‘file’ may be used uninitialized
> [-Werror=maybe-uninitialized]
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> migration/dirtyrate.c | 4 ++--
> migration/migration.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 1d2e85746f..22dd22922c 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -144,12 +144,12 @@ int64_t vcpu_calculate_dirtyrate(int64_t
> calc_time_ms,
> unsigned int flag,
> bool one_shot)
> {
> - DirtyPageRecord *records;
> + DirtyPageRecord *records = NULL;
> int64_t init_time_ms;
> int64_t duration;
> int64_t dirtyrate;
> int i = 0;
> - unsigned int gen_id;
> + unsigned int gen_id = 0;
>
> retry:
> init_time_ms = qemu_clock_get_ms(QEMU_CLOCK_REALTIME);
> diff --git a/migration/migration.c b/migration/migration.c
> index 9fe8fd2afd..412138ea94 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -2247,7 +2247,7 @@ static bool
> migrate_handle_rp_resume_ack(MigrationState *s,
> */
> static void migration_release_dst_files(MigrationState *ms)
> {
> - QEMUFile *file;
> + QEMUFile *file = NULL;
>
> WITH_QEMU_LOCK_GUARD(&ms->qemu_file_lock) {
> /*
> --
> 2.44.0
>
>
Reviewed-by: Hyman Huang <yong.hu...@smartx.com>
Yong
--
Best regards
