Re: [PATCH] Compress lines for immediate return

2020-04-01 Thread Simran Singhal
On Wed, Apr 1, 2020 at 9:15 PM Eric Blake wrote: > On 4/1/20 9:49 AM, Simran Singhal wrote: > > Hello Philippe > > > > On Wed, Apr 1, 2020 at 7:26 PM Philippe Mathieu-Daudé > > > wrote: > > > >> Hi Simran, > >> > >> On 4/1/20 2:11 PM, Simran Singhal wrote: > >>> Compress two lines into a single

Re: [PATCH] Compress lines for immediate return

2020-04-01 Thread Eric Blake
On 4/1/20 9:49 AM, Simran Singhal wrote: Hello Philippe On Wed, Apr 1, 2020 at 7:26 PM Philippe Mathieu-Daudé wrote: Hi Simran, On 4/1/20 2:11 PM, Simran Singhal wrote: Compress two lines into a single line if immediate return statement is found. How did you find these changes? Manual aud

Re: [PATCH] Compress lines for immediate return

2020-04-01 Thread Simran Singhal
Hello Philippe On Wed, Apr 1, 2020 at 7:26 PM Philippe Mathieu-Daudé wrote: > Hi Simran, > > On 4/1/20 2:11 PM, Simran Singhal wrote: > > Compress two lines into a single line if immediate return statement is > found. > > How did you find these changes? Manual audit, some tool? > I wrote coccin

[PATCH] Compress lines for immediate return

2020-04-01 Thread Simran Singhal
Compress two lines into a single line if immediate return statement is found. It also remove variables progress, val, data, ret and sock as they are no longer needed. Remove space between function "mixer_load" and '(' to fix the checkpatch.pl error:- ERROR: space prohibited between function name

Re: [PATCH] Compress lines for immediate return

2020-04-01 Thread Philippe Mathieu-Daudé
Hi Simran, On 4/1/20 2:11 PM, Simran Singhal wrote: Compress two lines into a single line if immediate return statement is found. How did you find these changes? Manual audit, some tool? It also remove variables progress, val, data, ret and sock as they are no longer needed. Remove space b

Re: [PATCH] Compress lines for immediate return

2020-04-01 Thread Dr. David Alan Gilbert
* Simran Singhal (singhalsimr...@gmail.com) wrote: > Compress two lines into a single line if immediate return statement is found. > > It also remove variables progress, val, data, ret and sock > as they are no longer needed. > > Remove space between function "mixer_load" and '(' to fix the > che