Re: [PATCH] block/snapshot: Fix compiler warning with -Wshadow=local

2023-10-23 Thread Thomas Huth
On 23/10/2023 17.26, Markus Armbruster wrote: Thomas Huth writes: No need to declare a new variable in the the inner code block here, we can re-use the "ret" variable that has been declared at the beginning of the function. With this change, the code can now be successfully compiled with -Wsha

Re: [PATCH] block/snapshot: Fix compiler warning with -Wshadow=local

2023-10-23 Thread Markus Armbruster
Thomas Huth writes: > No need to declare a new variable in the the inner code block > here, we can re-use the "ret" variable that has been declared > at the beginning of the function. With this change, the code > can now be successfully compiled with -Wshadow=local again. > > Fixes: a32e781838 ("

[PATCH] block/snapshot: Fix compiler warning with -Wshadow=local

2023-10-23 Thread Thomas Huth
No need to declare a new variable in the the inner code block here, we can re-use the "ret" variable that has been declared at the beginning of the function. With this change, the code can now be successfully compiled with -Wshadow=local again. Fixes: a32e781838 ("Mark bdrv_snapshot_fallback() and