Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-07-13 Thread Max Reitz
On 17.06.20 20:27, Sorry :/ Connor Kuehl wrote: > Providing an empty string for the backing file parameter like so: > > qemu-img create -f qcow2 -b '' /tmp/foo > > allows the flow of control to reach and subsequently fail an assert > statement because passing an empty string to > >

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-07-10 Thread Connor Kuehl
Ping On 7/1/20 3:42 PM, Connor Kuehl wrote: Hi Kevin & Max, Just pinging this patch for your consideration. Thank you, Connor On 6/17/20 11:27 AM, Connor Kuehl wrote: Providing an empty string for the backing file parameter like so: qemu-img create -f qcow2 -b '' /tmp/foo allows the

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-07-01 Thread Connor Kuehl
Hi Kevin & Max, Just pinging this patch for your consideration. Thank you, Connor On 6/17/20 11:27 AM, Connor Kuehl wrote: Providing an empty string for the backing file parameter like so: qemu-img create -f qcow2 -b '' /tmp/foo allows the flow of control to reach and subsequently

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-06-18 Thread Alberto Garcia
On Wed 17 Jun 2020 08:27:25 PM CEST, Connor Kuehl wrote: > Providing an empty string for the backing file parameter like so: > > qemu-img create -f qcow2 -b '' /tmp/foo > > allows the flow of control to reach and subsequently fail an assert > statement because passing an empty string to > >

[PATCH] block: Raise an error when backing file parameter is an empty string

2020-06-17 Thread Connor Kuehl
Providing an empty string for the backing file parameter like so: qemu-img create -f qcow2 -b '' /tmp/foo allows the flow of control to reach and subsequently fail an assert statement because passing an empty string to bdrv_get_full_backing_filename_from_filename() simply

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-06-17 Thread Eric Blake
On 6/17/20 1:27 PM, Connor Kuehl wrote: Providing an empty string for the backing file parameter like so: qemu-img create -f qcow2 -b '' /tmp/foo allows the flow of control to reach and subsequently fail an assert statement because passing an empty string to

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-06-17 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200617182725.951119-1-cku...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash