Re: [PATCH] block: use the request length for iov alignment

2022-09-23 Thread Kevin Wolf
Am 20.09.2022 um 21:27 hat Keith Busch geschrieben: > On Wed, Sep 14, 2022 at 11:36:14AM +0100, Kevin Wolf wrote: > > Am 13.09.2022 um 15:12 hat Keith Busch geschrieben: > > > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: > > > > From: Keith Busch > > > > > > > > An iov length need

Re: [PATCH] block: use the request length for iov alignment

2022-09-20 Thread Keith Busch
On Wed, Sep 14, 2022 at 11:36:14AM +0100, Kevin Wolf wrote: > Am 13.09.2022 um 15:12 hat Keith Busch geschrieben: > > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: > > > From: Keith Busch > > > > > > An iov length needs to be aligned to the logical block size, which may > > > be la

Re: [PATCH] block: use the request length for iov alignment

2022-09-15 Thread Keith Busch
On Wed, Sep 14, 2022 at 11:36:14AM +0100, Kevin Wolf wrote: > Am 13.09.2022 um 15:12 hat Keith Busch geschrieben: > > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: > > > From: Keith Busch > > > > > > An iov length needs to be aligned to the logical block size, which may > > > be la

Re: [PATCH] block: use the request length for iov alignment

2022-09-14 Thread Kevin Wolf
Am 13.09.2022 um 15:12 hat Keith Busch geschrieben: > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: > > From: Keith Busch > > > > An iov length needs to be aligned to the logical block size, which may > > be larger than the memory alignment. > > [cc'ing some other interested folks

Re: [PATCH] block: use the request length for iov alignment

2022-09-13 Thread Keith Busch
On Tue, Sep 13, 2022 at 03:20:23PM +0100, Damien Le Moal wrote: > On 2022/09/13 15:12, Keith Busch wrote: > > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: > >> From: Keith Busch > >> > >> An iov length needs to be aligned to the logical block size, which may > >> be larger than the

Re: [PATCH] block: use the request length for iov alignment

2022-09-13 Thread Damien Le Moal
On 2022/09/13 15:51, Keith Busch wrote: > On Tue, Sep 13, 2022 at 03:20:23PM +0100, Damien Le Moal wrote: >> On 2022/09/13 15:12, Keith Busch wrote: >>> On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: From: Keith Busch An iov length needs to be aligned to the logical bl

Re: [PATCH] block: use the request length for iov alignment

2022-09-13 Thread Damien Le Moal
On 2022/09/13 15:36, Keith Busch wrote: > On Tue, Sep 13, 2022 at 03:20:23PM +0100, Damien Le Moal wrote: >> On 2022/09/13 15:12, Keith Busch wrote: >>> On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: From: Keith Busch An iov length needs to be aligned to the logical bl

Re: [PATCH] block: use the request length for iov alignment

2022-09-13 Thread Keith Busch
On Tue, Sep 13, 2022 at 03:20:23PM +0100, Damien Le Moal wrote: > On 2022/09/13 15:12, Keith Busch wrote: > > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: > >> From: Keith Busch > >> > >> An iov length needs to be aligned to the logical block size, which may > >> be larger than the

Re: [PATCH] block: use the request length for iov alignment

2022-09-13 Thread Jens Axboe
On 9/13/22 8:12 AM, Keith Busch wrote: > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: >> From: Keith Busch >> >> An iov length needs to be aligned to the logical block size, which may >> be larger than the memory alignment. > > [cc'ing some other interested folks] > > Any thought

Re: [PATCH] block: use the request length for iov alignment

2022-09-13 Thread Damien Le Moal
On 2022/09/13 15:12, Keith Busch wrote: > On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: >> From: Keith Busch >> >> An iov length needs to be aligned to the logical block size, which may >> be larger than the memory alignment. > > [cc'ing some other interested folks] > > Any though

Re: [PATCH] block: use the request length for iov alignment

2022-09-13 Thread Keith Busch
On Thu, Sep 08, 2022 at 09:45:26AM -0700, Keith Busch wrote: > From: Keith Busch > > An iov length needs to be aligned to the logical block size, which may > be larger than the memory alignment. [cc'ing some other interested folks] Any thoughts on this patch? It is fixing an observed IO error

[PATCH] block: use the request length for iov alignment

2022-09-08 Thread Keith Busch
From: Keith Busch An iov length needs to be aligned to the logical block size, which may be larger than the memory alignment. Signed-off-by: Keith Busch --- block/io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/io.c b/block/io.c index 0a8cbefe86..296d4b49a7 100