Re: [PATCH] blockjob: report a better error message

2021-02-24 Thread Stefano Garzarella
On Wed, Feb 24, 2021 at 06:04:14PM +0100, Kevin Wolf wrote: Am 24.02.2021 um 16:59 hat Stefano Garzarella geschrieben: On Wed, Feb 24, 2021 at 03:36:20PM +0100, Kevin Wolf wrote: > Am 23.02.2021 um 14:11 hat Stefano Garzarella geschrieben: > > When a block job fails, we report

Re: [PATCH] blockjob: report a better error message

2021-02-24 Thread Kevin Wolf
Am 24.02.2021 um 16:59 hat Stefano Garzarella geschrieben: > On Wed, Feb 24, 2021 at 03:36:20PM +0100, Kevin Wolf wrote: > > Am 23.02.2021 um 14:11 hat Stefano Garzarella geschrieben: > > > When a block job fails, we report 'strerror(-job->job.ret)' error > > > message, also if the job set an

Re: [PATCH] blockjob: report a better error message

2021-02-24 Thread Stefano Garzarella
On Wed, Feb 24, 2021 at 03:36:20PM +0100, Kevin Wolf wrote: Am 23.02.2021 um 14:11 hat Stefano Garzarella geschrieben: When a block job fails, we report 'strerror(-job->job.ret)' error message, also if the job set an error object. Let's report a better error message using

Re: [PATCH] blockjob: report a better error message

2021-02-24 Thread Kevin Wolf
Am 23.02.2021 um 14:11 hat Stefano Garzarella geschrieben: > When a block job fails, we report 'strerror(-job->job.ret)' error > message, also if the job set an error object. > Let's report a better error message using 'error_get_pretty(job->job.err)'. > > If an error object was not set,

[PATCH] blockjob: report a better error message

2021-02-23 Thread Stefano Garzarella
When a block job fails, we report 'strerror(-job->job.ret)' error message, also if the job set an error object. Let's report a better error message using 'error_get_pretty(job->job.err)'. If an error object was not set, strerror(-job->ret) is used as fallback, as explained in include/qemu/job.h: