Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2022-10-31 Thread Klaus Jensen
On Oct 21 14:59, Daniel Wagner wrote: > On Tue, Oct 18, 2022 at 10:15:57AM +0200, Daniel Wagner wrote: > > On Mon, Oct 10, 2022 at 07:15:08PM +0200, Klaus Jensen wrote: > > > This is all upstream. Namespaces with 'shared=on' *should* all be > > > automatically attached to any hotplugged controller

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2022-10-21 Thread Daniel Wagner
On Tue, Oct 18, 2022 at 10:15:57AM +0200, Daniel Wagner wrote: > On Mon, Oct 10, 2022 at 07:15:08PM +0200, Klaus Jensen wrote: > > This is all upstream. Namespaces with 'shared=on' *should* all be > > automatically attached to any hotplugged controller devices. > > > > With what setup is this not

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2022-10-18 Thread Daniel Wagner
On Mon, Oct 10, 2022 at 07:15:08PM +0200, Klaus Jensen wrote: > This is all upstream. Namespaces with 'shared=on' *should* all be > automatically attached to any hotplugged controller devices. > > With what setup is this not working for you? Ah okay, I missed the 'shared=on' bit. Let me try again

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2022-10-12 Thread Klaus Jensen
On Okt 12 08:24, Hannes Reinecke wrote: > On 10/10/22 19:01, Daniel Wagner wrote: > > On Tue, May 11, 2021 at 06:12:47PM +0200, Hannes Reinecke wrote: > > > On 5/11/21 6:03 PM, Klaus Jensen wrote: > > > > On May 11 16:54, Hannes Reinecke wrote: > > > > > On 5/11/21 3:37 PM, Klaus Jensen wrote: > >

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2022-10-11 Thread Hannes Reinecke
On 10/10/22 19:01, Daniel Wagner wrote: On Tue, May 11, 2021 at 06:12:47PM +0200, Hannes Reinecke wrote: On 5/11/21 6:03 PM, Klaus Jensen wrote: On May 11 16:54, Hannes Reinecke wrote: On 5/11/21 3:37 PM, Klaus Jensen wrote: On May 11 15:12, Hannes Reinecke wrote: On 5/11/21 2:22 PM, Klaus J

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2022-10-10 Thread Klaus Jensen
On Okt 10 19:01, Daniel Wagner wrote: > On Tue, May 11, 2021 at 06:12:47PM +0200, Hannes Reinecke wrote: > > On 5/11/21 6:03 PM, Klaus Jensen wrote: > > > On May 11 16:54, Hannes Reinecke wrote: > > > > On 5/11/21 3:37 PM, Klaus Jensen wrote: > > > > > On May 11 15:12, Hannes Reinecke wrote: > > >

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2022-10-10 Thread Daniel Wagner
On Tue, May 11, 2021 at 06:12:47PM +0200, Hannes Reinecke wrote: > On 5/11/21 6:03 PM, Klaus Jensen wrote: > > On May 11 16:54, Hannes Reinecke wrote: > > > On 5/11/21 3:37 PM, Klaus Jensen wrote: > > > > On May 11 15:12, Hannes Reinecke wrote: > > > > > On 5/11/21 2:22 PM, Klaus Jensen wrote: > >

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Hannes Reinecke
On 5/11/21 6:03 PM, Klaus Jensen wrote: On May 11 16:54, Hannes Reinecke wrote: On 5/11/21 3:37 PM, Klaus Jensen wrote: On May 11 15:12, Hannes Reinecke wrote: On 5/11/21 2:22 PM, Klaus Jensen wrote: [ .. ] The hotplug fix looks good - I'll post a series that tries to integrate both. Ta.

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Klaus Jensen
On May 11 16:54, Hannes Reinecke wrote: On 5/11/21 3:37 PM, Klaus Jensen wrote: On May 11 15:12, Hannes Reinecke wrote: On 5/11/21 2:22 PM, Klaus Jensen wrote: [ .. ] The hotplug fix looks good - I'll post a series that tries to integrate both. Ta. The more I think about it, the more I thi

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Hannes Reinecke
On 5/11/21 3:37 PM, Klaus Jensen wrote: > On May 11 15:12, Hannes Reinecke wrote: >> On 5/11/21 2:22 PM, Klaus Jensen wrote: [ .. ] >>> The hotplug fix looks good - I'll post a series that tries to integrate >>> both. >>> >> Ta. >> >> The more I think about it, the more I think we should be looking

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Klaus Jensen
On May 11 15:12, Hannes Reinecke wrote: On 5/11/21 2:22 PM, Klaus Jensen wrote: On May 11 09:35, Hannes Reinecke wrote: Ever since commit e570768566 ("hw/block/nvme: support for shared namespace in subsystem") NVMe PCI hotplug is broken, as the PCI hotplug infrastructure will only work for the

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Hannes Reinecke
On 5/11/21 2:22 PM, Klaus Jensen wrote: > On May 11 09:35, Hannes Reinecke wrote: >> Ever since commit e570768566 ("hw/block/nvme: support for shared >> namespace in subsystem") NVMe PCI hotplug is broken, as the PCI >> hotplug infrastructure will only work for the nvme devices (which >> are PCI de

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Klaus Jensen
On May 11 09:35, Hannes Reinecke wrote: Ever since commit e570768566 ("hw/block/nvme: support for shared namespace in subsystem") NVMe PCI hotplug is broken, as the PCI hotplug infrastructure will only work for the nvme devices (which are PCI devices), but not for any attached namespaces. So when

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Philippe Mathieu-Daudé
Cc'ing Klaus (maintainer) On 5/11/21 9:35 AM, Hannes Reinecke wrote: > Ever since commit e570768566 ("hw/block/nvme: support for shared > namespace in subsystem") NVMe PCI hotplug is broken, as the PCI > hotplug infrastructure will only work for the nvme devices (which > are PCI devices), but not

Re: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210511073511.32511-1-h...@suse.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210511073511.32511-1-h...@suse.de Subject: [PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

[PATCH] hw/block/nvme: re-enable NVMe PCI hotplug

2021-05-11 Thread Hannes Reinecke
Ever since commit e570768566 ("hw/block/nvme: support for shared namespace in subsystem") NVMe PCI hotplug is broken, as the PCI hotplug infrastructure will only work for the nvme devices (which are PCI devices), but not for any attached namespaces. So when re-adding the NVMe PCI device via 'device