Re: [PATCH] hw/nvme: reenable cqe batching

2022-11-01 Thread Klaus Jensen
On Oct 20 13:35, Klaus Jensen wrote: > From: Klaus Jensen > > Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell > updates") had the unintended effect of disabling batching of CQEs. > > This patch changes the sq/cq timers to bottom halfs and instead of > calling nvme_post_cqes() imm

Re: [PATCH] hw/nvme: reenable cqe batching

2022-10-20 Thread Jinhao Fan
at 1:37 PM, Klaus Jensen wrote: > On Okt 21 10:37, Jinhao Fan wrote: >> at 7:35 PM, Klaus Jensen wrote: >> >>> Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell >>> updates") had the unintended effect of disabling batching of CQEs. >>> >>> This patch changes the sq/cq timers to b

Re: [PATCH] hw/nvme: reenable cqe batching

2022-10-20 Thread Klaus Jensen
On Okt 21 10:37, Jinhao Fan wrote: > at 7:35 PM, Klaus Jensen wrote: > > > Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell > > updates") had the unintended effect of disabling batching of CQEs. > > > > This patch changes the sq/cq timers to bottom halfs and instead of > > calling

Re: [PATCH] hw/nvme: reenable cqe batching

2022-10-20 Thread Jinhao Fan
at 7:35 PM, Klaus Jensen wrote: > Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell > updates") had the unintended effect of disabling batching of CQEs. > > This patch changes the sq/cq timers to bottom halfs and instead of > calling nvme_post_cqes() immediately (causing an interru

Re: [PATCH] hw/nvme: reenable cqe batching

2022-10-20 Thread Keith Busch
On Thu, Oct 20, 2022 at 01:35:38PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell > updates") had the unintended effect of disabling batching of CQEs. > > This patch changes the sq/cq timers to bottom halfs and instead of > cal

[PATCH] hw/nvme: reenable cqe batching

2022-10-20 Thread Klaus Jensen
From: Klaus Jensen Commit 2e53b0b45024 ("hw/nvme: Use ioeventfd to handle doorbell updates") had the unintended effect of disabling batching of CQEs. This patch changes the sq/cq timers to bottom halfs and instead of calling nvme_post_cqes() immediately (causing an interrupt per cqe), we defer t