Re: [PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

2021-01-26 Thread Mauro Matteo Cascella
On Mon, Jan 25, 2021 at 3:52 PM Philippe Mathieu-Daudé wrote: > > You forgot to Cc the subsystem maintainers... > > ./scripts/get_maintainer.pl -f hw/scsi/megasas.c > Hannes Reinecke (supporter:megasas) > Paolo Bonzini (supporter:SCSI) > Fam Zheng (reviewer:SCSI) I used to only check the

Re: [PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

2021-01-25 Thread Philippe Mathieu-Daudé
You forgot to Cc the subsystem maintainers... ./scripts/get_maintainer.pl -f hw/scsi/megasas.c Hannes Reinecke (supporter:megasas) Paolo Bonzini (supporter:SCSI) Fam Zheng (reviewer:SCSI) On 1/25/21 3:22 PM, Mauro Matteo Cascella wrote: > Hello, > > Any updates on this little patch? Please

Re: [PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

2021-01-25 Thread Mauro Matteo Cascella
Hello, Any updates on this little patch? Please find below a reproducer for this bug (thanks Alexander): https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg02567.html Thank you, On Thu, Dec 24, 2020 at 6:55 PM Mauro Matteo Cascella wrote: > > Ensure that 'cmd->frame' is not NULL

Re: [PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

2021-01-12 Thread Alexander Bulekov
Looks like one reported by OSS-Fuzz: Here's a reproducer cat << EOF | ./qemu-system-i386 -qtest stdio -display none \ -machine q35,accel=qtest -m 512M -nodefaults \ -device megasas -device scsi-cd,drive=null0 \ -blockdev driver=null-co,read-zeroes=on,node-name=null0 outl 0xcf8 0x8801 outl

[PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

2020-12-24 Thread Mauro Matteo Cascella
Ensure that 'cmd->frame' is not NULL before accessing the 'header' field. This check prevents a potential NULL pointer dereference issue. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1910346 Signed-off-by: Mauro Matteo Cascella Reported-by: Cheolwoo Myung --- hw/scsi/megasas.c | 2 +- 1