RE: [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings

2020-03-10 Thread Chenqun (kuhn)
er Robot ; Paolo Bonzini > >Subject: Re: [PATCH] hw/scsi/megasas:Clean up some redundant code fix >Clang warnings > >Le 10/03/2020 à 14:08, Chen Qun a écrit : >> Here are some redundant statements, we can clean them up. >> Clang static code analyzer show warning: >

RE: [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings

2020-03-10 Thread Chenqun (kuhn)
r Robot >; Paolo Bonzini >Subject: Re: [PATCH] hw/scsi/megasas:Clean up some redundant code fix >Clang warnings > >On Tue, 10 Mar 2020 at 13:10, Chen Qun >wrote: >> >> Here are some redundant statements, we can clean them up. >> Clang static code analyzer show war

Re: [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings

2020-03-10 Thread Laurent Vivier
Le 10/03/2020 à 14:46, Peter Maydell a écrit : > On Tue, 10 Mar 2020 at 13:10, Chen Qun wrote: >> >> Here are some redundant statements, we can clean them up. >> Clang static code analyzer show warning: >> hw/scsi/megasas.c:1175:32: warning: Value stored to 'max_ld_disks' during >> its initializa

Re: [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings

2020-03-10 Thread Laurent Vivier
Le 10/03/2020 à 14:08, Chen Qun a écrit : > Here are some redundant statements, we can clean them up. > Clang static code analyzer show warning: > hw/scsi/megasas.c:1175:32: warning: Value stored to 'max_ld_disks' during its > initialization is never read > uint32_t num_ld_disks = 0, max_ld_di

Re: [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings

2020-03-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200310130844.30076-1-kuhn.chen...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings

2020-03-10 Thread Peter Maydell
On Tue, 10 Mar 2020 at 13:10, Chen Qun wrote: > > Here are some redundant statements, we can clean them up. > Clang static code analyzer show warning: > hw/scsi/megasas.c:1175:32: warning: Value stored to 'max_ld_disks' during its > initialization is never read > uint32_t num_ld_disks = 0, ma

[PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings

2020-03-10 Thread Chen Qun
Here are some redundant statements, we can clean them up. Clang static code analyzer show warning: hw/scsi/megasas.c:1175:32: warning: Value stored to 'max_ld_disks' during its initialization is never read uint32_t num_ld_disks = 0, max_ld_disks = s->fw_luns; ^~~