Re: [PATCH] qcow2: Allow resize of images with internal snapshots

2020-04-23 Thread Eric Blake
On 4/23/20 12:21 PM, Max Reitz wrote: The previous comment was incorrect as well, but actually qcow2_truncate_bitmaps_check() doesn’t return an error when there is any bitmap, but only if there are non-active bitmaps, or active bitmaps that cannot be modified.  So for non-disabled bitmaps, we ge

Re: [PATCH] qcow2: Allow resize of images with internal snapshots

2020-04-23 Thread Max Reitz
On 23.04.20 16:35, Eric Blake wrote: > On 4/23/20 8:55 AM, Max Reitz wrote: >> On 22.04.20 22:53, Eric Blake wrote: >>> We originally refused to allow resize of images with internal >>> snapshots because the v2 image format did not require the tracking of >>> snapshot size, making it impossible to

Re: [PATCH] qcow2: Allow resize of images with internal snapshots

2020-04-23 Thread Eric Blake
On 4/23/20 8:55 AM, Max Reitz wrote: On 22.04.20 22:53, Eric Blake wrote: We originally refused to allow resize of images with internal snapshots because the v2 image format did not require the tracking of snapshot size, making it impossible to safely revert to a snapshot with a different size t

Re: [PATCH] qcow2: Allow resize of images with internal snapshots

2020-04-23 Thread Max Reitz
On 22.04.20 22:53, Eric Blake wrote: > We originally refused to allow resize of images with internal > snapshots because the v2 image format did not require the tracking of > snapshot size, making it impossible to safely revert to a snapshot > with a different size than the current view of the imag

[PATCH] qcow2: Allow resize of images with internal snapshots

2020-04-22 Thread Eric Blake
We originally refused to allow resize of images with internal snapshots because the v2 image format did not require the tracking of snapshot size, making it impossible to safely revert to a snapshot with a different size than the current view of the image. But the snapshot size tracking was rectif