Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-11-15 Thread Eric Blake
On 10/8/19 8:38 AM, Daniel P. Berrangé wrote: On Tue, Oct 08, 2019 at 08:28:16AM -0500, Eric Blake wrote: On 10/8/19 4:40 AM, Vladimir Sementsov-Ogievskiy wrote: 08.10.2019 12:24, Daniel P. Berrangé wrote: On Mon, Oct 07, 2019 at 02:48:40PM -0500, Eric Blake wrote: One benefit of --pid-file i

Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-08 Thread Eric Blake
On 10/8/19 8:53 AM, Vladimir Sementsov-Ogievskiy wrote: I've already implemented loop of attempting to connect in my series (patch 4/3). It's a bit more difficult to implement, but it's done. And it's a bit better, as it test exactly what we want to test. Can we proceed with it? For test pur

Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-08 Thread Vladimir Sementsov-Ogievskiy
08.10.2019 16:38, Daniel P. Berrangé wrote: > On Tue, Oct 08, 2019 at 08:28:16AM -0500, Eric Blake wrote: >> On 10/8/19 4:40 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 08.10.2019 12:24, Daniel P. Berrangé wrote: On Mon, Oct 07, 2019 at 02:48:40PM -0500, Eric Blake wrote: > One benefit of

Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-08 Thread Daniel P . Berrangé
On Tue, Oct 08, 2019 at 08:28:16AM -0500, Eric Blake wrote: > On 10/8/19 4:40 AM, Vladimir Sementsov-Ogievskiy wrote: > > 08.10.2019 12:24, Daniel P. Berrangé wrote: > > > On Mon, Oct 07, 2019 at 02:48:40PM -0500, Eric Blake wrote: > > > > One benefit of --pid-file is that it is easier to probe the

Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-08 Thread Eric Blake
On 10/8/19 4:40 AM, Vladimir Sementsov-Ogievskiy wrote: 08.10.2019 12:24, Daniel P. Berrangé wrote: On Mon, Oct 07, 2019 at 02:48:40PM -0500, Eric Blake wrote: One benefit of --pid-file is that it is easier to probe the file system to see if a pid file has been created than it is to probe if a

Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-08 Thread Vladimir Sementsov-Ogievskiy
08.10.2019 12:24, Daniel P. Berrangé wrote: > On Mon, Oct 07, 2019 at 02:48:40PM -0500, Eric Blake wrote: >> One benefit of --pid-file is that it is easier to probe the file >> system to see if a pid file has been created than it is to probe if a >> socket is available for connection. Document that

Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-08 Thread Daniel P . Berrangé
On Mon, Oct 07, 2019 at 02:48:40PM -0500, Eric Blake wrote: > One benefit of --pid-file is that it is easier to probe the file > system to see if a pid file has been created than it is to probe if a > socket is available for connection. Document that this is an > intentional feature. I'm not seein

Re: [PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-08 Thread Max Reitz
On 07.10.19 21:48, Eric Blake wrote: > One benefit of --pid-file is that it is easier to probe the file > system to see if a pid file has been created than it is to probe if a > socket is available for connection. Document that this is an > intentional feature. > > Signed-off-by: Eric Blake > ---

[PATCH] qemu-nbd: Document benefit of --pid-file

2019-10-07 Thread Eric Blake
One benefit of --pid-file is that it is easier to probe the file system to see if a pid file has been created than it is to probe if a socket is available for connection. Document that this is an intentional feature. Signed-off-by: Eric Blake --- qemu-nbd.texi | 3 ++- 1 file changed, 2 insertio