Re: [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

2019-11-22 Thread Kevin Wolf
Am 22.11.2019 um 11:15 hat Dr. David Alan Gilbert geschrieben: > * Maxim Levitsky (mlevi...@redhat.com) wrote: > > This patch series is bunch of cleanups > > to the hmp monitor code. > > > > This series only touched blockdev related hmp handlers. > > Hi Maxim, > This looks mostly OK to me from

Re: [PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

2019-11-22 Thread Dr. David Alan Gilbert
* Maxim Levitsky (mlevi...@redhat.com) wrote: > This patch series is bunch of cleanups > to the hmp monitor code. > > This series only touched blockdev related hmp handlers. Hi Maxim, This looks mostly OK to me from the HMP side - with one change; can you please move the blockdev-hmp-cmds.c int

[PATCH 0/9] RFC: [for 5.0]: HMP monitor handlers cleanups

2019-11-20 Thread Maxim Levitsky
This patch series is bunch of cleanups to the hmp monitor code. This series only touched blockdev related hmp handlers. No functional changes expected other that light error message changes by the last patch. This was inspired by this bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1719169