Re: [PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

2022-04-20 Thread Daniel P . Berrangé
On Wed, Apr 20, 2022 at 05:10:51PM +0100, Peter Maydell wrote: > On Wed, 20 Apr 2022 at 16:04, Daniel P. Berrangé wrote: > > > > On Wed, Apr 20, 2022 at 05:25:49PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > Could use a commit message explaining why this is a

Re: [PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

2022-04-20 Thread Peter Maydell
On Wed, 20 Apr 2022 at 16:04, Daniel P. Berrangé wrote: > > On Wed, Apr 20, 2022 at 05:25:49PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > Could use a commit message explaining why this is a good > idea. > > I see it contains QEMU_COPYRIGHT macro, but it also then >

Re: [PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

2022-04-20 Thread Marc-André Lureau
Hi On Wed, Apr 20, 2022 at 7:17 PM Daniel P. Berrangé wrote: > On Wed, Apr 20, 2022 at 05:25:49PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > Could use a commit message explaining why this is a good > idea. > > I see it contains QEMU_COPYRIGHT macro, but it also

Re: [PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

2022-04-20 Thread Daniel P . Berrangé
On Wed, Apr 20, 2022 at 05:25:49PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau Could use a commit message explaining why this is a good idea. I see it contains QEMU_COPYRIGHT macro, but it also then contains QEMU_HELP_BOTTOM which is about bug reporting not copyright.

Re: [PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

2022-04-20 Thread Warner Losh
On Wed, Apr 20, 2022 at 7:26 AM wrote: > From: Marc-André Lureau > > Suggested-by: Peter Maydell > Signed-off-by: Marc-André Lureau > Reviewed-by: Warner Losh > --- > include/{qemu-common.h => qemu/copyright.h} | 0 > bsd-user/main.c | 2 +- >

[PATCH 06/41] include: rename qemu-common.h qemu/copyright.h

2022-04-20 Thread marcandre . lureau
From: Marc-André Lureau Suggested-by: Peter Maydell Signed-off-by: Marc-André Lureau --- include/{qemu-common.h => qemu/copyright.h} | 0 bsd-user/main.c | 2 +- linux-user/main.c | 2 +- qemu-img.c | 2 +-