Re: [PATCH 08/20] python/machine.py: fix _popen access

2020-10-08 Thread John Snow
On 10/8/20 3:04 AM, Kevin Wolf wrote: The major downside that I saw while reviewing this patch (besides having extra code just for making the error message of what essentially a failed assertion nicer) is that we have two names for the same thing, we have both names in active use in the other met

Re: [PATCH 08/20] python/machine.py: fix _popen access

2020-10-08 Thread Kevin Wolf
Am 07.10.2020 um 20:44 hat John Snow geschrieben: > On 10/7/20 6:07 AM, Kevin Wolf wrote: > > Am 07.10.2020 um 01:58 hat John Snow geschrieben: > > > As always, Optional[T] causes problems with unchecked access. Add a > > > helper that asserts the pipe is present before we attempt to talk with > >

Re: [PATCH 08/20] python/machine.py: fix _popen access

2020-10-07 Thread John Snow
On 10/7/20 6:07 AM, Kevin Wolf wrote: Am 07.10.2020 um 01:58 hat John Snow geschrieben: As always, Optional[T] causes problems with unchecked access. Add a helper that asserts the pipe is present before we attempt to talk with it. Signed-off-by: John Snow First a question about the preexisti

Re: [PATCH 08/20] python/machine.py: fix _popen access

2020-10-07 Thread Kevin Wolf
Am 07.10.2020 um 01:58 hat John Snow geschrieben: > As always, Optional[T] causes problems with unchecked access. Add a > helper that asserts the pipe is present before we attempt to talk with > it. > > Signed-off-by: John Snow First a question about the preexisting state: I see that after initi

[PATCH 08/20] python/machine.py: fix _popen access

2020-10-06 Thread John Snow
As always, Optional[T] causes problems with unchecked access. Add a helper that asserts the pipe is present before we attempt to talk with it. Signed-off-by: John Snow --- python/qemu/machine.py | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/python/qemu/mac