Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-04-02 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 2 Apr 2020 at 07:55, Markus Armbruster wrote: >> Peter Maydell writes: >> > I use this thing maybe once a month at most, more likely once >> > every three months, and the documentation is notoriously >> > impenetrable. I really really don't want to have to start

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-04-02 Thread Peter Maydell
On Thu, 2 Apr 2020 at 07:55, Markus Armbruster wrote: > Peter Maydell writes: > > I use this thing maybe once a month at most, more likely once > > every three months, and the documentation is notoriously > > impenetrable. I really really don't want to have to start looking in it > > and guessing

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-04-01 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 1 Apr 2020 at 15:44, Markus Armbruster wrote: >> Peter Maydell writes: >> > On Wed, 1 Apr 2020 at 06:07, Markus Armbruster wrote: >> > But then as a coccinelle script author I need to know which of >> > the options I needed are standard, which are for-this-scrip

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-04-01 Thread Peter Maydell
On Wed, 1 Apr 2020 at 15:44, Markus Armbruster wrote: > Peter Maydell writes: > > On Wed, 1 Apr 2020 at 06:07, Markus Armbruster wrote: > > But then as a coccinelle script author I need to know which of > > the options I needed are standard, which are for-this-script-only, > > and which are just

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-04-01 Thread Markus Armbruster
Peter Maydell writes: > On Wed, 1 Apr 2020 at 06:07, Markus Armbruster wrote: > >> Generic instructions for using .cocci scripts should go into README. >> Enough to get you started if you know nothing about Coccinelle. >> >> Options that should always be used with a certain script should be >> d

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-04-01 Thread Peter Maydell
On Wed, 1 Apr 2020 at 06:07, Markus Armbruster wrote: > Generic instructions for using .cocci scripts should go into README. > Enough to get you started if you know nothing about Coccinelle. > > Options that should always be used with a certain script should be > documented in that script. > > Op

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Markus Armbruster
Peter Maydell writes: > On Tue, 31 Mar 2020 at 10:01, Markus Armbruster wrote: >> I doubt including basic spatch instructions with every script is a good >> idea. Better explain it in one place, with proper maintenance. >> scripts/coccinelle/README? We could be a bit more verbose there, >> e.g

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Peter Maydell
On Tue, 31 Mar 2020 at 10:01, Markus Armbruster wrote: > I doubt including basic spatch instructions with every script is a good > idea. Better explain it in one place, with proper maintenance. > scripts/coccinelle/README? We could be a bit more verbose there, > e.g. to clarify required vs. sugg

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 31.03.2020 16:14, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> 31.03.2020 12:00, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: > Add script to find and fix trivial use-after-free of Error objects. >>

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Vladimir Sementsov-Ogievskiy
31.03.2020 16:14, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 31.03.2020 12:00, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add script to find and fix trivial use-after-free of Error objects. How to use: spatch --sp-file scripts/coccinelle/auto-propagate

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 31.03.2020 12:00, Markus Armbruster wrote: >> Vladimir Sementsov-Ogievskiy writes: >> >>> Add script to find and fix trivial use-after-free of Error objects. >>> How to use: >>> spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ >>> --macro-

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Vladimir Sementsov-Ogievskiy
31.03.2020 12:00, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add script to find and fix trivial use-after-free of Error objects. How to use: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place \ --no-show-di

Re: [PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-31 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Add script to find and fix trivial use-after-free of Error objects. > How to use: > spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ > --macro-file scripts/cocci-macro-file.h --in-place \ > --no-show-diff ( FILES... | --use-gitgrep . ) Pas

[PATCH 1/6] scripts/coccinelle: add error-use-after-free.cocci

2020-03-24 Thread Vladimir Sementsov-Ogievskiy
Add script to find and fix trivial use-after-free of Error objects. How to use: spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \ --macro-file scripts/cocci-macro-file.h --in-place \ --no-show-diff ( FILES... | --use-gitgrep . ) Signed-off-by: Vladimir Sementsov-Ogievskiy --- sc