Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-17 Thread Cédric Le Goater
On 3/16/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from bad

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 14:04, Philippe Mathieu-Daudé wrote: On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Marc-André Lureau
On Wed, Mar 16, 2022 at 5:04 PM Philippe Mathieu-Daudé wrote: > > On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Replace a config-time define with a compile time condition > > define (compatible with clang and gcc) that must be declared prior to > > its

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Philippe Mathieu-Daudé
On 16/3/22 10:53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from bad

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Halil Pasic
On Wed, 16 Mar 2022 13:53:07 +0400 marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Replace a config-time define with a compile time condition > define (compatible with clang and gcc) that must be declared prior to > its usage. This avoids having a global configure time define,

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Marc-André Lureau
Hi On Wed, Mar 16, 2022 at 3:16 PM Halil Pasic wrote: > > On Wed, 16 Mar 2022 11:28:59 +0100 > Thomas Huth wrote: > > > On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Replace a config-time define with a compile time condition > > > define

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Thomas Huth
On 16/03/2022 12.15, Halil Pasic wrote: On Wed, 16 Mar 2022 11:28:59 +0100 Thomas Huth wrote: On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Halil Pasic
On Wed, 16 Mar 2022 11:28:59 +0100 Thomas Huth wrote: > On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Replace a config-time define with a compile time condition > > define (compatible with clang and gcc) that must be declared prior to > > its

Re: [PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread Thomas Huth
On 16/03/2022 10.53, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from

[PATCH 10/27] Replace config-time define HOST_WORDS_BIGENDIAN

2022-03-16 Thread marcandre . lureau
From: Marc-André Lureau Replace a config-time define with a compile time condition define (compatible with clang and gcc) that must be declared prior to its usage. This avoids having a global configure time define, but also prevents from bad usage, if the config header wasn't included before.