Re: [PATCH 12/23] qemu-img: make -l (list) the default for "snapshot" subcommand

20.02.2024 21:51, Michael Tokarev wrote: 20.02.2024 20:45, Daniel P. Berrangé wrote: On Sat, Feb 10, 2024 at 12:22:33AM +0300, Michael Tokarev wrote: also remove bdrv_oflags handling (only list can use RO mode) ---   qemu-img.c | 13 -   1 file changed, 8 insertions(+), 5 deletions(-

Re: [PATCH 12/23] qemu-img: make -l (list) the default for "snapshot" subcommand

20.02.2024 20:45, Daniel P. Berrangé wrote: On Sat, Feb 10, 2024 at 12:22:33AM +0300, Michael Tokarev wrote: also remove bdrv_oflags handling (only list can use RO mode) --- qemu-img.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) I'd suggest docs/tools/qemu-img.rst sh

Re: [PATCH 12/23] qemu-img: make -l (list) the default for "snapshot" subcommand

On Sat, Feb 10, 2024 at 12:22:33AM +0300, Michael Tokarev wrote: > also remove bdrv_oflags handling (only list can use RO mode) > --- > qemu-img.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) I'd suggest docs/tools/qemu-img.rst should also be updated to say Lists all sn

[PATCH 12/23] qemu-img: make -l (list) the default for "snapshot" subcommand

also remove bdrv_oflags handling (only list can use RO mode) --- qemu-img.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 1e09b78d00..d9dfff2f07 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3541,7 +3541,7 @@ static int img_snapshot(