Re: [PATCH 16/17] block/nvme: Check BDRVNVMeState::plugged out of nvme_kick()

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 08:48:37PM +0200, Philippe Mathieu-Daudé wrote: > The queues are tied to the hardware, not to the block driver. > As this function doesn't need to know about the BDRVNVMeState, > move the 'plugged' check to the caller. > Since in nvme_aio_unplug() we know that s->plugged is

[PATCH 16/17] block/nvme: Check BDRVNVMeState::plugged out of nvme_kick()

2020-06-25 Thread Philippe Mathieu-Daudé
The queues are tied to the hardware, not to the block driver. As this function doesn't need to know about the BDRVNVMeState, move the 'plugged' check to the caller. Since in nvme_aio_unplug() we know that s->plugged is false, we don't need the check. Signed-off-by: Philippe Mathieu-Daudé --- blo