Re: [PATCH 16/25] block/nvme: Simplify ADMIN queue access

2020-10-28 Thread Stefan Hajnoczi
On Tue, Oct 27, 2020 at 02:55:38PM +0100, Philippe Mathieu-Daudé wrote: > We don't need to dereference from BDRVNVMeState each time. > Use a NVMeQueuePair pointer to the admin queue and use it. > The nvme_init() becomes easier to review, matching the style > of nvme_add_io_queue(). > > Signed-off-

Re: [PATCH 16/25] block/nvme: Simplify ADMIN queue access

2020-10-28 Thread Auger Eric
On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote: > We don't need to dereference from BDRVNVMeState each time. > Use a NVMeQueuePair pointer to the admin queue and use it. double "use" > The nvme_init() becomes easier to review, matching the style > of nvme_add_io_queue().> > Signed-off-by: Phi

[PATCH 16/25] block/nvme: Simplify ADMIN queue access

2020-10-27 Thread Philippe Mathieu-Daudé
We don't need to dereference from BDRVNVMeState each time. Use a NVMeQueuePair pointer to the admin queue and use it. The nvme_init() becomes easier to review, matching the style of nvme_add_io_queue(). Signed-off-by: Philippe Mathieu-Daudé --- block/nvme.c | 12 ++-- 1 file changed, 6 i