Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-12 Thread Peter Lieven
> Am 12.01.2022 um 22:57 schrieb Ilya Dryomov : > > On Wed, Jan 12, 2022 at 9:37 PM Peter Lieven wrote: >> >>> Am 12.01.22 um 20:51 schrieb Ilya Dryomov: >>> On Wed, Jan 12, 2022 at 1:32 PM Peter Lieven wrote: Am 12.01.22 um 13:22 schrieb Ilya Dryomov: > On Wed, Jan 12, 2022 at 12:

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-12 Thread Ilya Dryomov
On Wed, Jan 12, 2022 at 9:37 PM Peter Lieven wrote: > > Am 12.01.22 um 20:51 schrieb Ilya Dryomov: > > On Wed, Jan 12, 2022 at 1:32 PM Peter Lieven wrote: > >> Am 12.01.22 um 13:22 schrieb Ilya Dryomov: > >>> On Wed, Jan 12, 2022 at 12:55 PM Peter Lieven wrote: > Am 12.01.22 um 10:59 schrie

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-12 Thread Peter Lieven
Am 12.01.22 um 20:51 schrieb Ilya Dryomov: > On Wed, Jan 12, 2022 at 1:32 PM Peter Lieven wrote: >> Am 12.01.22 um 13:22 schrieb Ilya Dryomov: >>> On Wed, Jan 12, 2022 at 12:55 PM Peter Lieven wrote: Am 12.01.22 um 10:59 schrieb Ilya Dryomov: > On Mon, Jan 10, 2022 at 12:43 PM Peter Liev

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-12 Thread Ilya Dryomov
On Wed, Jan 12, 2022 at 12:55 PM Peter Lieven wrote: > > Am 12.01.22 um 10:59 schrieb Ilya Dryomov: > > On Mon, Jan 10, 2022 at 12:43 PM Peter Lieven wrote: > >> librbd had a bug until early 2022 that affected all versions of ceph that > >> supported fast-diff. This bug results in reporting of in

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-12 Thread Peter Lieven
Am 12.01.22 um 10:59 schrieb Ilya Dryomov: > On Mon, Jan 10, 2022 at 12:43 PM Peter Lieven wrote: >> librbd had a bug until early 2022 that affected all versions of ceph that >> supported fast-diff. This bug results in reporting of incorrect offsets >> if the offset parameter to rbd_diff_iterate2

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-12 Thread Ilya Dryomov
On Mon, Jan 10, 2022 at 12:43 PM Peter Lieven wrote: > > librbd had a bug until early 2022 that affected all versions of ceph that > supported fast-diff. This bug results in reporting of incorrect offsets > if the offset parameter to rbd_diff_iterate2 is not object aligned. > Work around this bug

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-11 Thread Stefano Garzarella
Hi Peter, On Tue, Jan 11, 2022 at 10:10:16AM +0100, Peter Lieven wrote: Hi Stefano, thanks for the feedback. Please note that you also need the other patch or you will sooner or later run into another assertion as soon as rbd snapshots are involved. Yep, I tested with the entire series app

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-11 Thread Peter Lieven
Am 10.01.22 um 15:18 schrieb Stefano Garzarella: > On Mon, Jan 10, 2022 at 12:41:54PM +0100, Peter Lieven wrote: >> librbd had a bug until early 2022 that affected all versions of ceph that >> supported fast-diff. This bug results in reporting of incorrect offsets >> if the offset parameter to rbd_

Re: [PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-10 Thread Stefano Garzarella
On Mon, Jan 10, 2022 at 12:41:54PM +0100, Peter Lieven wrote: librbd had a bug until early 2022 that affected all versions of ceph that supported fast-diff. This bug results in reporting of incorrect offsets if the offset parameter to rbd_diff_iterate2 is not object aligned. Work around this bug

[PATCH 2/2] block/rbd: workaround for ceph issue #53784

2022-01-10 Thread Peter Lieven
librbd had a bug until early 2022 that affected all versions of ceph that supported fast-diff. This bug results in reporting of incorrect offsets if the offset parameter to rbd_diff_iterate2 is not object aligned. Work around this bug by rounding down the offset to object boundaries. Fixes: https: