Re: [PATCH 2/2] qcow2: dump QCOW2 metadata

2020-01-13 Thread Eric Blake
On 1/13/20 11:02 AM, Andrey Shinkevich wrote: +++ b/qemu-img.texi @@ -230,7 +230,7 @@ specified as well.    For write tests, by default a buffer filled with zeros is written. This can be    overridden with a pattern byte specified by @var{pattern}. -@item check [--object @var{objectdef}] [--im

Re: [PATCH 2/2] qcow2: dump QCOW2 metadata

2020-01-13 Thread Andrey Shinkevich
On 13/01/2020 19:16, Eric Blake wrote: > On 1/13/20 4:30 AM, Andrey Shinkevich wrote: > -    c = getopt_long(argc, argv, ":hf:r:T:qU", +    c = getopt_long(argc, argv, ":hf:r:T:qU:M", >>> >>> We are already inconsistent, but I tend to add options in alphabetical >>> order, bot

Re: [PATCH 2/2] qcow2: dump QCOW2 metadata

2020-01-13 Thread Eric Blake
On 1/13/20 4:30 AM, Andrey Shinkevich wrote: -    c = getopt_long(argc, argv, ":hf:r:T:qU", +    c = getopt_long(argc, argv, ":hf:r:T:qU:M", We are already inconsistent, but I tend to add options in alphabetical order, both here... If I merely move 'M' forward like ':hf:M:r:T:qU', w

Re: [PATCH 2/2] qcow2: dump QCOW2 metadata

2020-01-13 Thread Andrey Shinkevich
On 08/01/2020 01:11, Eric Blake wrote: > On 12/27/19 5:43 AM, Andrey Shinkevich wrote: >> Let QEMU-IMG CHECK command show QCOW2 structure to inform a user about >> metadata allocations on disk. Introduce '-M'('--dump-meta') key option. >> >> Suggested-by: Vladimir Sementsov-Ogievskiy >> Signed-o

Re: [PATCH 2/2] qcow2: dump QCOW2 metadata

2020-01-07 Thread Eric Blake
On 12/27/19 5:43 AM, Andrey Shinkevich wrote: Let QEMU-IMG CHECK command show QCOW2 structure to inform a user about metadata allocations on disk. Introduce '-M'('--dump-meta') key option. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- +++ b/qemu-img.c @@ -1

[PATCH 2/2] qcow2: dump QCOW2 metadata

2019-12-27 Thread Andrey Shinkevich
Let QEMU-IMG CHECK command show QCOW2 structure to inform a user about metadata allocations on disk. Introduce '-M'('--dump-meta') key option. Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich --- block/qcow2-bitmap.c | 53 --- block/qcow2