Re: [PATCH 20/20] migration: remove the QEMUFileOps abstraction

2022-06-09 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > Now that all QEMUFile callbacks are removed, the entire concept can be > deleted. > > Signed-off-by: Daniel P. Berrangé I think that's OK, there's one nit - you remove qemu_get_fd from one of the headers; I think that probably belongs in an ear

Re: [PATCH 20/20] migration: remove the QEMUFileOps abstraction

2022-06-09 Thread Daniel P . Berrangé
On Thu, Jun 09, 2022 at 05:59:00PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > Now that all QEMUFile callbacks are removed, the entire concept can be > > deleted. > > > > Signed-off-by: Daniel P. Berrangé > > I think that's OK, there's one nit - y

[PATCH 20/20] migration: remove the QEMUFileOps abstraction

2022-05-24 Thread Daniel P . Berrangé
Now that all QEMUFile callbacks are removed, the entire concept can be deleted. Signed-off-by: Daniel P. Berrangé --- migration/channel.c | 4 +-- migration/colo.c | 5 ++-- migration/meson.build | 1 - migration/migration.c | 7 ++--- migration/qemu-fi