Re: [PATCH 3/4] Move CONFIG_XFS handling to meson.build

2021-12-14 Thread Thomas Huth
On 10/12/2021 11.10, Paolo Bonzini wrote: On 12/10/21 09:46, Thomas Huth wrote: platform_test_xfs_fd() is only used to decide whether to invoke XFS_IOC_DIOINFO; but failures of XFS_IOC_DIOINFO are ignored anyway, so we can get rid of is_xfs in BDRVRawState, too. After staring at the code

Re: [PATCH 3/4] Move CONFIG_XFS handling to meson.build

2021-12-10 Thread Paolo Bonzini
On 12/10/21 09:46, Thomas Huth wrote: platform_test_xfs_fd() is only used to decide whether to invoke XFS_IOC_DIOINFO; but failures of XFS_IOC_DIOINFO are ignored anyway, so we can get rid of is_xfs in BDRVRawState, too. After staring at the code for a while, I wonder why we're not simply

Re: [PATCH 3/4] Move CONFIG_XFS handling to meson.build

2021-12-10 Thread Thomas Huth
On 10/12/2021 09.39, Paolo Bonzini wrote: On 12/10/21 08:53, Thomas Huth wrote: On 02/11/2021 12.34, Paolo Bonzini wrote: On 28/10/21 20:59, Thomas Huth wrote: Checking for xfsctl() can be done more easily in meson.build. Also, this is not a "real" feature like the other features that we

Re: [PATCH 3/4] Move CONFIG_XFS handling to meson.build

2021-12-10 Thread Paolo Bonzini
On 12/10/21 08:53, Thomas Huth wrote: On 02/11/2021 12.34, Paolo Bonzini wrote: On 28/10/21 20:59, Thomas Huth wrote: Checking for xfsctl() can be done more easily in meson.build. Also, this is not a "real" feature like the other features that we provide with the "--enable-xxx" and

Re: [PATCH 3/4] Move CONFIG_XFS handling to meson.build

2021-12-09 Thread Thomas Huth
On 02/11/2021 12.34, Paolo Bonzini wrote: On 28/10/21 20:59, Thomas Huth wrote: Checking for xfsctl() can be done more easily in meson.build. Also, this is not a "real" feature like the other features that we provide with the "--enable-xxx" and "--disable-xxx" switches for the configure script,

Re: [PATCH 3/4] Move CONFIG_XFS handling to meson.build

2021-11-02 Thread Paolo Bonzini
On 02/11/21 12:38, Thomas Huth wrote: struct dioattr { u32   d_mem;  /* data buffer memory alignment */ u32   d_miniosz;  /* min xfer size    */ u32   d_maxiosz;  /* max xfer size    */ }; #define

Re: [PATCH 3/4] Move CONFIG_XFS handling to meson.build

2021-11-02 Thread Thomas Huth
On 02/11/2021 12.34, Paolo Bonzini wrote: On 28/10/21 20:59, Thomas Huth wrote: Checking for xfsctl() can be done more easily in meson.build. Also, this is not a "real" feature like the other features that we provide with the "--enable-xxx" and "--disable-xxx" switches for the configure script,