Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 03:03:30PM +0200, Lukas Straub wrote: > On Fri, 15 May 2020 11:26:13 +0100 > Daniel P. Berrangé wrote: > > > On Fri, May 15, 2020 at 12:14:47PM +0200, Lukas Straub wrote: > > > On Fri, 15 May 2020 11:04:13 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Fri,

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Lukas Straub
On Fri, 15 May 2020 11:26:13 +0100 Daniel P. Berrangé wrote: > On Fri, May 15, 2020 at 12:14:47PM +0200, Lukas Straub wrote: > > On Fri, 15 May 2020 11:04:13 +0100 > > Daniel P. Berrangé wrote: > > > > > On Fri, May 15, 2020 at 11:48:18AM +0200, Lukas Straub wrote: > > > > On Tue, 12 May

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 12:14:47PM +0200, Lukas Straub wrote: > On Fri, 15 May 2020 11:04:13 +0100 > Daniel P. Berrangé wrote: > > > On Fri, May 15, 2020 at 11:48:18AM +0200, Lukas Straub wrote: > > > On Tue, 12 May 2020 09:54:58 +0100 > > > Daniel P. Berrangé wrote: > > > > > > > On Mon,

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Lukas Straub
On Fri, 15 May 2020 11:04:13 +0100 Daniel P. Berrangé wrote: > On Fri, May 15, 2020 at 11:48:18AM +0200, Lukas Straub wrote: > > On Tue, 12 May 2020 09:54:58 +0100 > > Daniel P. Berrangé wrote: > > > > > On Mon, May 11, 2020 at 07:05:24PM +0200, Lukas Straub wrote: > > > > On Mon, 11 May

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Daniel P . Berrangé
On Fri, May 15, 2020 at 11:48:18AM +0200, Lukas Straub wrote: > On Tue, 12 May 2020 09:54:58 +0100 > Daniel P. Berrangé wrote: > > > On Mon, May 11, 2020 at 07:05:24PM +0200, Lukas Straub wrote: > > > On Mon, 11 May 2020 17:19:09 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > *

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-15 Thread Lukas Straub
On Tue, 12 May 2020 09:54:58 +0100 Daniel P. Berrangé wrote: > On Mon, May 11, 2020 at 07:05:24PM +0200, Lukas Straub wrote: > > On Mon, 11 May 2020 17:19:09 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Lukas Straub (lukasstra...@web.de) wrote: > > > > Add yank option, pass it to

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-12 Thread Daniel P . Berrangé
On Mon, May 11, 2020 at 07:05:24PM +0200, Lukas Straub wrote: > On Mon, 11 May 2020 17:19:09 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Lukas Straub (lukasstra...@web.de) wrote: > > > Add yank option, pass it to the socket-channel and register a yank > > > function which sets s->state =

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-11 Thread Dr. David Alan Gilbert
* Lukas Straub (lukasstra...@web.de) wrote: > On Mon, 11 May 2020 17:19:09 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Lukas Straub (lukasstra...@web.de) wrote: > > > Add yank option, pass it to the socket-channel and register a yank > > > function which sets s->state = NBD_CLIENT_QUIT. This

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-11 Thread Lukas Straub
On Mon, 11 May 2020 17:19:09 +0100 "Dr. David Alan Gilbert" wrote: > * Lukas Straub (lukasstra...@web.de) wrote: > > Add yank option, pass it to the socket-channel and register a yank > > function which sets s->state = NBD_CLIENT_QUIT. This is the same > > behaviour as if an error occured. > >

Re: [PATCH 3/5] block/nbd.c: Add yank feature

2020-05-11 Thread Dr. David Alan Gilbert
* Lukas Straub (lukasstra...@web.de) wrote: > Add yank option, pass it to the socket-channel and register a yank > function which sets s->state = NBD_CLIENT_QUIT. This is the same > behaviour as if an error occured. > > Signed-off-by: Lukas Straub > +static void nbd_yank(void *opaque) > +{ > +

[PATCH 3/5] block/nbd.c: Add yank feature

2020-05-11 Thread Lukas Straub
Add yank option, pass it to the socket-channel and register a yank function which sets s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an error occured. Signed-off-by: Lukas Straub --- Makefile.objs| 1 + block/nbd.c | 68