Re: [PATCH 4/5] virtio: Fail if iommu_platform is requested, but unsupported

2021-04-29 Thread Raphael Norwitz
Got it - thanks for the clarification. Reviewed-by: Raphael Norwitz On Thu, Apr 29, 2021 at 11:34:11AM +0200, Kevin Wolf wrote: > Am 28.04.2021 um 21:24 hat Raphael Norwitz geschrieben: > > On Thu, Apr 22, 2021 at 07:02:20PM +0200, Kevin Wolf wrote: > > > Commit 2943b53f6 (' virtio: force

Re: [PATCH 4/5] virtio: Fail if iommu_platform is requested, but unsupported

2021-04-29 Thread Kevin Wolf
Am 28.04.2021 um 21:24 hat Raphael Norwitz geschrieben: > On Thu, Apr 22, 2021 at 07:02:20PM +0200, Kevin Wolf wrote: > > Commit 2943b53f6 (' virtio: force VIRTIO_F_IOMMU_PLATFORM') made sure > > that vhost can't just reject VIRTIO_F_IOMMU_PLATFORM when it was > > requested. However, just adding

Re: [PATCH 4/5] virtio: Fail if iommu_platform is requested, but unsupported

2021-04-28 Thread Raphael Norwitz
On Thu, Apr 22, 2021 at 07:02:20PM +0200, Kevin Wolf wrote: > Commit 2943b53f6 (' virtio: force VIRTIO_F_IOMMU_PLATFORM') made sure > that vhost can't just reject VIRTIO_F_IOMMU_PLATFORM when it was > requested. However, just adding it back to the negotiated flags isn't > right either because it

[PATCH 4/5] virtio: Fail if iommu_platform is requested, but unsupported

2021-04-22 Thread Kevin Wolf
Commit 2943b53f6 (' virtio: force VIRTIO_F_IOMMU_PLATFORM') made sure that vhost can't just reject VIRTIO_F_IOMMU_PLATFORM when it was requested. However, just adding it back to the negotiated flags isn't right either because it promises support to the guest that the device actually doesn't