Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

Daniel P. Berrangé wrote: >> > >> > This has a slight semantic behavioural change. >> >> Yeap. >> >> See the answer to Peter. But three things came to mind: >> >> a - the size of the buffer is small (between 32KB and 256KB depending >> how you count it). So we are going to call

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

On Thu, May 04, 2023 at 07:22:25PM +0200, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: > >> That is the moment we know we have transferred something. > >> > >> Signed-off-by: Juan Quintela > >> --- > >>

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

Daniel P. Berrangé wrote: > On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: >> That is the moment we know we have transferred something. >> >> Signed-off-by: Juan Quintela >> --- >> migration/qemu-file.c | 7 +++ >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: > That is the moment we know we have transferred something. > > Signed-off-by: Juan Quintela > --- > migration/qemu-file.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/migration/qemu-file.c

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

Peter Xu wrote: > On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: >> That is the moment we know we have transferred something. >> >> Signed-off-by: Juan Quintela > > There'll be a slight side effect that qemu_file_rate_limit() can be > triggered later than before because data

Re: [PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

On Thu, May 04, 2023 at 01:38:41PM +0200, Juan Quintela wrote: > That is the moment we know we have transferred something. > > Signed-off-by: Juan Quintela There'll be a slight side effect that qemu_file_rate_limit() can be triggered later than before because data cached in the qemufile won't

[PATCH 9/9] qemu-file: Account for rate_limit usage on qemu_fflush()

That is the moment we know we have transferred something. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index ddebfac847..309b4c56f4 100644 ---