Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-02-02 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Jan 29, 2021 at 02:25:56PM +0100, Paolo Bonzini wrote: >> On 29/01/21 13:17, Daniel P. Berrangé wrote: >> > > On this one, my vote would be "no". "Versioned machine names >> > > include the QEMU version number" is pretty well entrenched, >> > > and requiring

Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-02-01 Thread Eduardo Habkost
On Fri, Jan 29, 2021 at 02:25:56PM +0100, Paolo Bonzini wrote: > On 29/01/21 13:17, Daniel P. Berrangé wrote: > > > On this one, my vote would be "no". "Versioned machine names > > > include the QEMU version number" is pretty well entrenched, > > > and requiring users to remember that when they

Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-01-29 Thread Paolo Bonzini
On 29/01/21 13:17, Daniel P. Berrangé wrote: On this one, my vote would be "no". "Versioned machine names include the QEMU version number" is pretty well entrenched, and requiring users to remember that when they want version 4.2 they need to remember some other way of writing it than "4.2"

Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-01-29 Thread Markus Armbruster
Markus Armbruster writes: > QAPI has naming rules. docs/devel/qapi-code-gen.txt: > > === Naming rules and reserved names === > > All names must begin with a letter, and contain only ASCII letters, > digits, hyphen, and underscore. There are two exceptions: enum values > may

Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-01-29 Thread Daniel P . Berrangé
On Fri, Jan 29, 2021 at 12:01:53PM +, Peter Maydell wrote: > On Fri, 29 Jan 2021 at 08:15, Markus Armbruster wrote: > > 2. We have some 550 type names containing '.'. QAPI's naming rules > >could be relaxed to accept '.', but keyval_parse()'s can't. > > > >Aside: I wish

Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-01-29 Thread Peter Maydell
On Fri, 29 Jan 2021 at 08:15, Markus Armbruster wrote: > 2. We have some 550 type names containing '.'. QAPI's naming rules >could be relaxed to accept '.', but keyval_parse()'s can't. > >Aside: I wish keyval_parse() would use '/' instead of '.', but it's >designed to be compatible

Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-01-29 Thread Markus Armbruster
Forgot to mention: Based-on: <20210125162402.1807394-1-arm...@redhat.com> [PATCH 0/3] Drop deprecated floppy config & bogus -drive if=T

[PATCH RFC 0/1] QOM type names and QAPI

2021-01-29 Thread Markus Armbruster
QAPI has naming rules. docs/devel/qapi-code-gen.txt: === Naming rules and reserved names === All names must begin with a letter, and contain only ASCII letters, digits, hyphen, and underscore. There are two exceptions: enum values may start with a digit, and names that are