Re: [PATCH RFC 03/32] python//machine.py: remove bare except

2020-06-02 Thread John Snow
On 6/2/20 7:01 AM, Kevin Wolf wrote: > Am 14.05.2020 um 07:53 hat John Snow geschrieben: >> Catch only the timeout error; if there are other problems, allow the >> stack trace to be visible. >> >> Signed-off-by: John Snow > > Having a visible stack trace is nice, but don't we still want to kil

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

2020-06-02 Thread Kevin Wolf
Am 14.05.2020 um 07:53 hat John Snow geschrieben: > Catch only the timeout error; if there are other problems, allow the > stack trace to be visible. > > Signed-off-by: John Snow Having a visible stack trace is nice, but don't we still want to kill the qemu process to be sure that it's gone even

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

2020-05-26 Thread Philippe Mathieu-Daudé
On 5/14/20 7:53 AM, John Snow wrote: > Catch only the timeout error; if there are other problems, allow the > stack trace to be visible. > > Signed-off-by: John Snow > --- > python/qemu/lib/machine.py | 33 + > 1 file changed, 21 insertions(+), 12 deletions(-) >

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

2020-05-26 Thread Philippe Mathieu-Daudé
On 5/14/20 4:26 PM, John Snow wrote: > > > On 5/14/20 9:55 AM, Eric Blake wrote: >> On 5/14/20 12:53 AM, John Snow wrote: >>> Catch only the timeout error; if there are other problems, allow the >>> stack trace to be visible. >>> >> >> A lot of patches in this series start with "python//" - is th

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

2020-05-14 Thread John Snow
On 5/14/20 9:55 AM, Eric Blake wrote: > On 5/14/20 12:53 AM, John Snow wrote: >> Catch only the timeout error; if there are other problems, allow the >> stack trace to be visible. >> > > A lot of patches in this series start with "python//" - is that > intentional, or should it be a single slas

Re: [PATCH RFC 03/32] python//machine.py: remove bare except

2020-05-14 Thread Eric Blake
On 5/14/20 12:53 AM, John Snow wrote: Catch only the timeout error; if there are other problems, allow the stack trace to be visible. A lot of patches in this series start with "python//" - is that intentional, or should it be a single slash? Signed-off-by: John Snow --- python/qemu/lib

[PATCH RFC 03/32] python//machine.py: remove bare except

2020-05-13 Thread John Snow
Catch only the timeout error; if there are other problems, allow the stack trace to be visible. Signed-off-by: John Snow --- python/qemu/lib/machine.py | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/python/qemu/lib/machine.py b/python/qemu