Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-21 Thread Matt Johnston
On Fri, Nov 18, 2022 at 08:01:40AM +0100, Klaus Jensen wrote: > On Nov 18 13:56, Jeremy Kerr wrote: > > Hi Klaus, > > > > > Add an abstract MCTP over I2C endpoint model. This implements MCTP > > > control message handling as well as handling the actual I2C transport > > > (packetization). > > >

Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-17 Thread Jeremy Kerr
Hi Klaus, > I had to reverse the target mode functionality in QEMU from the linux > driver, so I am really not too sure if having START and STOP set in > the interrupt register is allowed behavior or not >From my interpretation of things, there's nothing explicitly preventing both a pending

Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-17 Thread Klaus Jensen
On Nov 18 14:15, Jeremy Kerr wrote: > Hi Klaus, > > > With those changes, I can get control protocol going, and multi- > > packet messages work. > > Ah, I also needed a change to the aspeed I2C driver, as I'm seeing > the interrupt handler being invoked with both a stop and a start event >

Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-17 Thread Klaus Jensen
On Nov 18 13:56, Jeremy Kerr wrote: > Hi Klaus, > > > Add an abstract MCTP over I2C endpoint model. This implements MCTP > > control message handling as well as handling the actual I2C transport > > (packetization). > > > > Devices are intended to derive from this and implement the class > >

Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-17 Thread Jeremy Kerr
Hi Klaus, > With those changes, I can get control protocol going, and multi- > packet messages work. Ah, I also needed a change to the aspeed I2C driver, as I'm seeing the interrupt handler being invoked with both a stop and a start event pending. Patch below; if this seems sensible I will

Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-17 Thread Jeremy Kerr
Hi Klaus, > Add an abstract MCTP over I2C endpoint model. This implements MCTP > control message handling as well as handling the actual I2C transport > (packetization). > > Devices are intended to derive from this and implement the class > methods. Looks good, nice to see how it's used by the

Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-16 Thread Klaus Jensen
On Nov 16 08:27, Corey Minyard wrote: > On Wed, Nov 16, 2022 at 09:43:11AM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Add an abstract MCTP over I2C endpoint model. This implements MCTP > > control message handling as well as handling the actual I2C transport > > (packetization). >

Re: [PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-16 Thread Corey Minyard
On Wed, Nov 16, 2022 at 09:43:11AM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Add an abstract MCTP over I2C endpoint model. This implements MCTP > control message handling as well as handling the actual I2C transport > (packetization). > > Devices are intended to derive from this and

[PATCH RFC 2/3] hw/i2c: add mctp core

2022-11-16 Thread Klaus Jensen
From: Klaus Jensen Add an abstract MCTP over I2C endpoint model. This implements MCTP control message handling as well as handling the actual I2C transport (packetization). Devices are intended to derive from this and implement the class methods. Parts of this implementation is inspired by