Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 11:23, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:04, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
22.08.2020 20:04, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f.  We can work around it by treating

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-22 Thread Vladimir Sementsov-Ogievskiy
22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f.  We can work around it by treating post-EOF fallocates as serializing up until infinity

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-22 Thread Vladimir Sementsov-Ogievskiy
01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f. We can work around it by treating post-EOF fallocates as serializing up until infinity (INT64_MAX in practice). Hi! I'm doing some

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2020 20:01, Vladimir Sementsov-Ogievskiy wrote: 02.06.2020 19:38, Max Reitz wrote: On 02.06.20 18:16, Vladimir Sementsov-Ogievskiy wrote: 02.06.2020 18:46, Max Reitz wrote: On 02.06.20 16:43, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: Sorry for being late,

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2020 19:38, Max Reitz wrote: On 02.06.20 18:16, Vladimir Sementsov-Ogievskiy wrote: 02.06.2020 18:46, Max Reitz wrote: On 02.06.20 16:43, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: Sorry for being late, I have some comments Uh, well.  Reasonable, but I

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Max Reitz
On 02.06.20 18:16, Vladimir Sementsov-Ogievskiy wrote: > 02.06.2020 18:46, Max Reitz wrote: >> On 02.06.20 16:43, Vladimir Sementsov-Ogievskiy wrote: >>> 01.11.2019 18:25, Max Reitz wrote: >>> >>> Sorry for being late, I have some comments >> >> Uh, well.  Reasonable, but I hope you don’t mind me

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2020 18:46, Max Reitz wrote: On 02.06.20 16:43, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: Sorry for being late, I have some comments Uh, well. Reasonable, but I hope you don’t mind me having no longer having this patch fresh on my mind. The XFS kernel

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Max Reitz
On 02.06.20 16:43, Vladimir Sementsov-Ogievskiy wrote: > 01.11.2019 18:25, Max Reitz wrote: > > Sorry for being late, I have some comments Uh, well. Reasonable, but I hope you don’t mind me having no longer having this patch fresh on my mind. >> The XFS kernel driver has a bug that may cause

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-06-02 Thread Vladimir Sementsov-Ogievskiy
01.11.2019 18:25, Max Reitz wrote: Sorry for being late, I have some comments The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f. We can work around it by treating post-EOF fallocates as serializing up until infinity (INT64_MAX in

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Max Reitz
On 14.11.19 18:15, Max Reitz wrote: > On 14.11.19 17:27, Christoph Hellwig wrote: >> On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: >>> The XFS kernel driver has a bug that may cause data corruption for qcow2 >>> images as of qemu commit c8bb23cbdbe32f. We can work around it by >>>

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Max Reitz
On 14.11.19 17:27, Christoph Hellwig wrote: > On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: >> The XFS kernel driver has a bug that may cause data corruption for qcow2 >> images as of qemu commit c8bb23cbdbe32f. We can work around it by >> treating post-EOF fallocates as serializing

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-14 Thread Christoph Hellwig
On Fri, Nov 01, 2019 at 04:25:10PM +0100, Max Reitz wrote: > The XFS kernel driver has a bug that may cause data corruption for qcow2 > images as of qemu commit c8bb23cbdbe32f. We can work around it by > treating post-EOF fallocates as serializing up until infinity (INT64_MAX > in practice).

[PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2019-11-01 Thread Max Reitz
The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f. We can work around it by treating post-EOF fallocates as serializing up until infinity (INT64_MAX in practice). Cc: qemu-sta...@nongnu.org Signed-off-by: Max Reitz ---