Re: [PATCH for-5.0 0/6] Several error use-after-free

2020-04-04 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Hi all! > > I accidentally found use-after-free of local_err in mirror, and decided > to search for similar cases with help of small coccinelle script > (patch 01). Happily, there no many cases. > > Better to fix zero Error* pointer after each freeing everyw

Re: [PATCH for-5.0 0/6] Several error use-after-free

2020-03-24 Thread Richard Henderson
On 3/24/20 8:36 AM, Vladimir Sementsov-Ogievskiy wrote: > Vladimir Sementsov-Ogievskiy (6): > scripts/coccinelle: add error-use-after-free.cocci > block/mirror: fix use after free of local_err > dump/win_dump: fix use after free of err > migration/colo: fix use after free of local_err > m

[PATCH for-5.0 0/6] Several error use-after-free

2020-03-24 Thread Vladimir Sementsov-Ogievskiy
Hi all! I accidentally found use-after-free of local_err in mirror, and decided to search for similar cases with help of small coccinelle script (patch 01). Happily, there no many cases. Better to fix zero Error* pointer after each freeing everywhere, but this is too much for 5.0 and most of thes