Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-19 Thread Alberto Garcia
On Fri 19 Jun 2020 09:57:27 AM CEST, Max Reitz wrote: >> If two images have the same contents but then you compare them >> changing the backing file of one of them you can also get a content >> mismatch. How is this different? > > It’s different in that files with data-file-raw can’t have backing

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-19 Thread Max Reitz
On 18.06.20 14:03, Alberto Garcia wrote: > On Wed 03 Jun 2020 03:53:03 PM CEST, Max Reitz wrote: >> Sorry for the long delay. :/ > > And sorry for my long delay as well. > >> The patch itself looks good, but I’m not sure whether it is extensive >> enough. Let me just jump straight to the

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-18 Thread Alberto Garcia
On Wed 03 Jun 2020 03:53:03 PM CEST, Max Reitz wrote: > Sorry for the long delay. :/ And sorry for my long delay as well. > The patch itself looks good, but I’m not sure whether it is extensive > enough. Let me just jump straight to the problem: > > $ ./qemu-img create -f qcow2 \ > -o

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-05 Thread Max Reitz
On 05.06.20 15:00, Kevin Wolf wrote: [...] > Makes sense. I'm not against preallocation during image creation. I just > think it shouldn't play a role in deciding whether an image is valid or > not. Oh, no. I wouldn’t consider it corrupted just because some clusters are not allocated. I’d

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-05 Thread Kevin Wolf
Am 05.06.2020 um 14:11 hat Max Reitz geschrieben: > On 05.06.20 13:14, Kevin Wolf wrote: > > Am 03.06.2020 um 15:53 hat Max Reitz geschrieben: > >> On 15.04.20 21:02, Alberto Garcia wrote: > >>> Although we cannot create these images with qemu-img it is still > >>> possible to do it using an

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-05 Thread Max Reitz
On 05.06.20 13:14, Kevin Wolf wrote: > Am 03.06.2020 um 15:53 hat Max Reitz geschrieben: >> On 15.04.20 21:02, Alberto Garcia wrote: >>> Although we cannot create these images with qemu-img it is still >>> possible to do it using an external tool. QEMU should refuse to open >>> them until the

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-05 Thread Kevin Wolf
Am 03.06.2020 um 15:53 hat Max Reitz geschrieben: > On 15.04.20 21:02, Alberto Garcia wrote: > > Although we cannot create these images with qemu-img it is still > > possible to do it using an external tool. QEMU should refuse to open > > them until the data-file-raw bit is cleared with 'qemu-img

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-03 Thread Max Reitz
On 15.04.20 21:02, Alberto Garcia wrote: > Although we cannot create these images with qemu-img it is still > possible to do it using an external tool. QEMU should refuse to open > them until the data-file-raw bit is cleared with 'qemu-img check'. > > Signed-off-by: Alberto Garcia > --- >

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-05-19 Thread Alberto Garcia
ping On Wed 15 Apr 2020 09:02:07 PM CEST, Alberto Garcia wrote: > Although we cannot create these images with qemu-img it is still > possible to do it using an external tool. QEMU should refuse to open > them until the data-file-raw bit is cleared with 'qemu-img check'. > > Signed-off-by: Alberto

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-04-15 Thread Eric Blake
On 4/15/20 2:02 PM, Alberto Garcia wrote: Although we cannot create these images with qemu-img it is still possible to do it using an external tool. QEMU should refuse to open them until the data-file-raw bit is cleared with 'qemu-img check'. Signed-off-by: Alberto Garcia --- block/qcow2.c

[PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-04-15 Thread Alberto Garcia
Although we cannot create these images with qemu-img it is still possible to do it using an external tool. QEMU should refuse to open them until the data-file-raw bit is cleared with 'qemu-img check'. Signed-off-by: Alberto Garcia --- block/qcow2.c | 39