Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-09-24 Thread Richard W.M. Jones
On Tue, Sep 24, 2024 at 09:52:04AM +0200, Thomas Huth wrote: > On 23/09/2024 18.03, Eric Blake wrote: > >On Sun, Sep 22, 2024 at 08:51:22PM GMT, Richard W.M. Jones wrote: > >>On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: > >>>On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Hu

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-09-24 Thread Thomas Huth
On 23/09/2024 18.03, Eric Blake wrote: On Sun, Sep 22, 2024 at 08:51:22PM GMT, Richard W.M. Jones wrote: On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: Since version 2.66, glib has useful URI parsing functions, t

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-09-23 Thread Richard W.M. Jones
On Mon, Sep 23, 2024 at 06:38:27PM +0200, Daniel P. Berrangé wrote: > On Mon, Sep 23, 2024 at 11:03:08AM -0500, Eric Blake wrote: > > On Sun, Sep 22, 2024 at 08:51:22PM GMT, Richard W.M. Jones wrote: > > > On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: > > > > On Thu, Mar 28, 2

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-09-23 Thread Daniel P . Berrangé
On Mon, Sep 23, 2024 at 11:03:08AM -0500, Eric Blake wrote: > On Sun, Sep 22, 2024 at 08:51:22PM GMT, Richard W.M. Jones wrote: > > On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: > > > On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: > > > > Since version 2.66, glib

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-09-23 Thread Eric Blake
On Sun, Sep 22, 2024 at 08:51:22PM GMT, Richard W.M. Jones wrote: > On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: > > On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: > > > Since version 2.66, glib has useful URI parsing functions, too. > > > Use those instead of t

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-09-22 Thread Richard W.M. Jones
On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: > On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: > > Since version 2.66, glib has useful URI parsing functions, too. > > Use those instead of the QEMU-internal ones to be finally able > > to get rid of the latter. The

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-04-04 Thread Richard W.M. Jones
On Thu, Mar 28, 2024 at 04:40:10PM +, Richard W.M. Jones wrote: > libnbd absolutely does *not* get this right, eg: > > $ nbdinfo NBD://localhost > nbdinfo: nbd_connect_uri: unknown NBD URI scheme: NBD: Invalid argument > > so that's a bug too. Proposed fix: https://gitlab.com/nbdkit/libn

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Richard W.M. Jones
On Thu, Mar 28, 2024 at 10:06:01AM -0500, Eric Blake wrote: > Adjusting cc list to add upstream NBD and drop developers unrelated to > this part of the qemu series... > > On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: > > On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth w

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Thomas Huth
On 28/03/2024 15.59, Daniel P. Berrangé wrote: On Thu, Mar 28, 2024 at 09:54:49AM -0500, Eric Blake wrote: On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Eric Blake
Adjusting cc list to add upstream NBD and drop developers unrelated to this part of the qemu series... On Thu, Mar 28, 2024 at 02:13:42PM +, Richard W.M. Jones wrote: > On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: > > Since version 2.66, glib has useful URI parsing functions, t

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Daniel P . Berrangé
On Thu, Mar 28, 2024 at 09:54:49AM -0500, Eric Blake wrote: > On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: > > Since version 2.66, glib has useful URI parsing functions, too. > > Use those instead of the QEMU-internal ones to be finally able > > to get rid of the latter. The g_uri_g

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Eric Blake
On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. The g_uri_get_host() also takes care > of removing the square brackets from IPv

Re: [PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Richard W.M. Jones
On Thu, Mar 28, 2024 at 03:06:03PM +0100, Thomas Huth wrote: > Since version 2.66, glib has useful URI parsing functions, too. > Use those instead of the QEMU-internal ones to be finally able > to get rid of the latter. The g_uri_get_host() also takes care > of removing the square brackets from IPv

[PATCH for-9.1 6/9] block/nbd: Use URI parsing code from glib

2024-03-28 Thread Thomas Huth
Since version 2.66, glib has useful URI parsing functions, too. Use those instead of the QEMU-internal ones to be finally able to get rid of the latter. The g_uri_get_host() also takes care of removing the square brackets from IPv6 addresses, so we can drop that part of the QEMU code now, too. Sig