On 29/09/2021 07.30, ~farzon wrote:
From: Farzon Lotfi <farz...@icloud.com>
Hi!
Thanks for your contribution! However, there are some more rules that need
to be followed to get a patch accepted in the QEMU project:
Please provide a proper patch description for your changes (something like:
"QEMU coding style mandates spaces for indentation, so the TABs should get
replaced in these files" or something similar should do it here).
Then it would be nice to have a "Resolves:" line in here, too:
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/371
That way, the issue gets closed automatically once the patch has been
accepted. Then please also drop the "issue 371:" from the subject line.
See also:
https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
And finally, the most important one: You need to supply a "Signed-off-by:"
line at the end of the patch description to make it clear that your patch
follows the Developer Certificat of Origin. See also:
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line
15 files changed, 639 insertions(+), 639 deletions(-)
I think the patch is rather big already. Could you please split it up in
three patches instead:
- One for block/ and include/block
- One for hw/block/ and include/hw/block
- One for hw/ide/ and include/hw/ide
Please also make sure to CC: qemu-block@nongnu.org on these patches (I
recommend to use the scripts/get_maintainer.pl script to get the right list
of people to put into the CC: list of the patches).
HTH,
Thomas
