Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-08 Thread Michael S. Tsirkin
On Fri, Nov 08, 2019 at 07:43:22AM +, Denis Plotnikov wrote: > The 1st patch from the series seems to be useless. The patch extending > queue length by adding machine type may break vm-s which use seabios > with max queue size = 128. > > Looks like only this patch doesn't break anything and

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-07 Thread Denis Plotnikov
The 1st patch from the series seems to be useless. The patch extending queue length by adding machine type may break vm-s which use seabios with max queue size = 128. Looks like only this patch doesn't break anything and helps to express queue size and seg max dependency (the specification

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-06 Thread Denis Lunev
On 11/5/19 9:51 PM, Michael S. Tsirkin wrote: > On Tue, Nov 05, 2019 at 07:11:03PM +0300, Denis Plotnikov wrote: >> seg_max has a restriction to be less or equal to virtqueue size >> according to Virtio 1.0 specification >> >> Although seg_max can't be set directly, it's worth to express this >>

Re: [PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-05 Thread Michael S. Tsirkin
On Tue, Nov 05, 2019 at 07:11:03PM +0300, Denis Plotnikov wrote: > seg_max has a restriction to be less or equal to virtqueue size > according to Virtio 1.0 specification > > Although seg_max can't be set directly, it's worth to express this > dependancy directly in the code for sanity purpose. >

[PATCH v1 2/4] virtio: make seg_max virtqueue size dependent

2019-11-05 Thread Denis Plotnikov
seg_max has a restriction to be less or equal to virtqueue size according to Virtio 1.0 specification Although seg_max can't be set directly, it's worth to express this dependancy directly in the code for sanity purpose. Signed-off-by: Denis Plotnikov --- hw/block/virtio-blk.c | 2 +-