Re: [PATCH v11 12/12] migration: introduce snapshot-{save,load,delete} QMP commands

2021-02-16 Thread John Snow
On 2/4/21 7:48 AM, Daniel P. Berrangé wrote: savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined.

Re: [PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands

2021-02-04 Thread Daniel P . Berrangé
On Thu, Feb 04, 2021 at 03:34:33PM +, Dr. David Alan Gilbert wrote: > This is (intermittently?) failing for me because of ordering issues: > > --- > /home/dgilbert/git/migpull/tests/qemu-iotests/tests/internal-snapshots-qapi.out > +++ internal-snapshots-qapi.out.bad > @@ -344,8 +344,8 @@ >

Re: [PATCH v11 12/12] migration: introduce snapshot-{save,load,delete} QMP commands

2021-02-04 Thread Eric Blake
On 2/4/21 6:48 AM, Daniel P. Berrangé wrote: > savevm, loadvm and delvm are some of the few HMP commands that have never > been converted to use QMP. The reasons for the lack of conversion are > that they blocked execution of the event thread, and the semantics > around choice of disks were

Re: [PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands

2021-02-04 Thread Dr. David Alan Gilbert
This is (intermittently?) failing for me because of ordering issues: --- /home/dgilbert/git/migpull/tests/qemu-iotests/tests/internal-snapshots-qapi.out +++ internal-snapshots-qapi.out.bad @@ -344,8 +344,8 @@ "vmstate": "diskfmt0",

[PATCH v11 12/12] migration: introduce snapshot-{save, load, delete} QMP commands

2021-02-04 Thread Daniel P . Berrangé
savevm, loadvm and delvm are some of the few HMP commands that have never been converted to use QMP. The reasons for the lack of conversion are that they blocked execution of the event thread, and the semantics around choice of disks were ill-defined. Despite this downside, however, libvirt and