Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-10 Thread Stefan Hajnoczi
On Tue, Mar 09, 2021 at 12:37:35AM +0900, Akihiko Odaki wrote: > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > The live migration compatibility issue is still present. Migrating to > > another host might not work if the block limits are different. > > > > Here is an idea for solving it: > > > > Modif

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-09 Thread Kevin Wolf
Am 09.03.2021 um 11:26 hat Daniel P. Berrangé geschrieben: > On Tue, Mar 09, 2021 at 10:37:18AM +0100, Kevin Wolf wrote: > > Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben: > > > 2021年3月9日(火) 0:37 Akihiko Odaki : > > > > > > > > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > > > > > > > The live

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-09 Thread Akihiko Odaki
2021年3月9日(火) 19:26 Daniel P. Berrangé : > > On Tue, Mar 09, 2021 at 10:37:18AM +0100, Kevin Wolf wrote: > > Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben: > > > 2021年3月9日(火) 0:37 Akihiko Odaki : > > > > > > > > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > > > > > > > The live migration compat

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-09 Thread Daniel P . Berrangé
On Tue, Mar 09, 2021 at 10:37:18AM +0100, Kevin Wolf wrote: > Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben: > > 2021年3月9日(火) 0:37 Akihiko Odaki : > > > > > > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > > > > > The live migration compatibility issue is still present. Migrating to > > > > ano

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-09 Thread Kevin Wolf
Am 09.03.2021 um 05:52 hat Akihiko Odaki geschrieben: > 2021年3月9日(火) 0:37 Akihiko Odaki : > > > > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > > > The live migration compatibility issue is still present. Migrating to > > > another host might not work if the block limits are different. > > > > > > He

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-08 Thread Akihiko Odaki
2021年3月9日(火) 0:37 Akihiko Odaki : > > 2021年3月9日(火) 0:17 Stefan Hajnoczi : > > > > The live migration compatibility issue is still present. Migrating to > > another host might not work if the block limits are different. > > > > Here is an idea for solving it: > > > > Modify include/hw/block/block.h:

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-08 Thread Akihiko Odaki
2021年3月9日(火) 0:17 Stefan Hajnoczi : > > The live migration compatibility issue is still present. Migrating to > another host might not work if the block limits are different. > > Here is an idea for solving it: > > Modify include/hw/block/block.h:DEFINE_BLOCK_PROPERTIES_BASE() to > support a new va

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-08 Thread Stefan Hajnoczi
On Fri, Mar 05, 2021 at 09:17:48PM +0900, Akihiko Odaki wrote: > This commit introduces "punch hole" operation and optimizes transfer > block size for macOS. > > This commit introduces two additional members, > discard_granularity and opt_io to BlockSizes type in > include/block/block.h. Also, the

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210305121748.65173-1-akihiko.od...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210305121748.65173-1-akihiko.od...@gmail.com Subject: [PATCH v2] block/file-posix

[PATCH v2] block/file-posix: Optimize for macOS

2021-03-05 Thread Akihiko Odaki
This commit introduces "punch hole" operation and optimizes transfer block size for macOS. This commit introduces two additional members, discard_granularity and opt_io to BlockSizes type in include/block/block.h. Also, the members of the type are now optional. Set -1 to discard_granularity and 0