Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-17 Thread Olaf Hering
Mon, 17 Jul 2023 08:46:16 + Bernhard Beschow : > Would you mind sending this patch as well? Sure, I was waiting for the other change to appear in the master branch, so I can reference it in the new commit message. Olaf pgp0aQ6E3JkxM.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-17 Thread Bernhard Beschow
Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering : >Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > >> I agree that calling pci_device_reset() would be a better match for >> pci_xen_ide_unplug(). > >This change works as well: > >--- a/hw/i386/xen/xen_platform.c >+++

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-11 Thread Bernhard Beschow
Am 11. Juli 2023 09:11:33 UTC schrieb Olaf Hering : >Wed, 05 Jul 2023 21:52:05 + Bernhard Beschow : > >> I wonder if we should fix this line rather than dropping it. > >I think this needs to be fixed, just to fix the initial commit which >added this bug. This will allow backporting this

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-11 Thread Bernhard Beschow
Am 1. Juli 2023 17:46:59 UTC schrieb Olaf Hering : >According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS >MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is >32bit wide. To properly reset it to default values, all 32bit need to be >cleared. Bit #0 "Resource

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-11 Thread Olaf Hering
Wed, 05 Jul 2023 21:52:05 + Bernhard Beschow : > I wonder if we should fix this line rather than dropping it. I think this needs to be fixed, just to fix the initial commit which added this bug. This will allow backporting this oneliner. Further changes to pci_xen_ide_unplug will be done in

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-05 Thread Bernhard Beschow
Am 5. Juli 2023 10:01:21 UTC schrieb Olaf Hering : >Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > >> I agree that calling pci_device_reset() would be a better match for >> pci_xen_ide_unplug(). > >This change works as well: Nice! > >--- a/hw/i386/xen/xen_platform.c >+++

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-05 Thread Olaf Hering
Tue, 4 Jul 2023 08:38:33 +0200 Paolo Bonzini : > I agree that calling pci_device_reset() would be a better match for > pci_xen_ide_unplug(). This change works as well: --- a/hw/i386/xen/xen_platform.c +++ b/hw/i386/xen/xen_platform.c @@ -164,8 +164,9 @@ static void pci_unplug_nics(PCIBus *bus)

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-04 Thread Paolo Bonzini
On 7/3/23 22:33, Bernhard Beschow wrote: Paolo, Peter: Should we switch to pci_device_reset() in pci_xen_ide_unplug()? Or is device_cold_reset() supposed to do everything? device_cold_reset() does not reset state that is part of the bus, so I think it's consistent that it doesn't call

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-03 Thread Bernhard Beschow
Am 3. Juli 2023 07:59:29 UTC schrieb Olaf Hering : >Sun, 02 Jul 2023 22:18:50 + Bernhard Beschow : > >> Do you know if that command calls pci_device_reset() (which would eventually >> call piix_ide_reset())? > >The function is pci_xen_ide_unplug, which calls device_cold_reset. I think

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-03 Thread Olaf Hering
Sun, 02 Jul 2023 22:18:50 + Bernhard Beschow : > Do you know if that command calls pci_device_reset() (which would eventually > call piix_ide_reset())? The function is pci_xen_ide_unplug, which calls device_cold_reset. Olaf pgpACvJNVWPYZ.pgp Description: Digitale Signatur von OpenPGP

Re: [PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-02 Thread Bernhard Beschow
Am 1. Juli 2023 17:46:59 UTC schrieb Olaf Hering : >According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS >MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is >32bit wide. To properly reset it to default values, all 32bit need to be >cleared. Bit #0 "Resource

[PATCH v2] hw/ide/piix: properly initialize the BMIBA register

2023-07-01 Thread Olaf Hering
According to the 82371FB documentation (82371FB.pdf, 2.3.9. BMIBA—BUS MASTER INTERFACE BASE ADDRESS REGISTER, April 1997), the register is 32bit wide. To properly reset it to default values, all 32bit need to be cleared. Bit #0 "Resource Type Indicator (RTE)" needs to be enabled. The initial