Re: [PATCH v2 00/22] qapi: Kill 'qapi/qmp/qerror.h' for good

2023-10-20 Thread Markus Armbruster
Your patches are sane, the problem is they made me look at the code they patch, much of which is not fine. Let's chat off list to figure out how to best get your patches merged.

Re: [PATCH v2 00/22] qapi: Kill 'qapi/qmp/qerror.h' for good

2023-10-05 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Since v1: > - Fixed checkpatch warnings (Juan) > - Added R-b tags > - New patch for 'vcpu_dirty_limit' > > Hi, > > This is kind of a selfish series. I'm really tired to grep > and read this comment from 2015 in qapi/qmp/qerror.h: > /* >* These macros

[PATCH v2 00/22] qapi: Kill 'qapi/qmp/qerror.h' for good

2023-10-04 Thread Philippe Mathieu-Daudé
Since v1: - Fixed checkpatch warnings (Juan) - Added R-b tags - New patch for 'vcpu_dirty_limit' Hi, This is kind of a selfish series. I'm really tired to grep and read this comment from 2015 in qapi/qmp/qerror.h: /* * These macros will go away, please don't use * in new code,