Re: [PATCH v2 04/20] qemu-file: We only call qemu_file_transferred_* on the sending side

Peter Xu wrote: > On Tue, Jun 13, 2023 at 06:02:05PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Tue, May 30, 2023 at 08:39:25PM +0200, Juan Quintela wrote: >> >> Remove the increase in qemu_file_fill_buffer() and add asserts to >> >> qemu_file_transferred* functions. >> >> >> >>

Re: [PATCH v2 04/20] qemu-file: We only call qemu_file_transferred_* on the sending side

On Tue, Jun 13, 2023 at 06:02:05PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Tue, May 30, 2023 at 08:39:25PM +0200, Juan Quintela wrote: > >> Remove the increase in qemu_file_fill_buffer() and add asserts to > >> qemu_file_transferred* functions. > >> > >> Signed-off-by: Juan Quintela

Re: [PATCH v2 04/20] qemu-file: We only call qemu_file_transferred_* on the sending side

Peter Xu wrote: > On Tue, May 30, 2023 at 08:39:25PM +0200, Juan Quintela wrote: >> Remove the increase in qemu_file_fill_buffer() and add asserts to >> qemu_file_transferred* functions. >> >> Signed-off-by: Juan Quintela > > The read side accounting does look a bit weird and never caught my

Re: [PATCH v2 04/20] qemu-file: We only call qemu_file_transferred_* on the sending side

On Tue, May 30, 2023 at 08:39:25PM +0200, Juan Quintela wrote: > Remove the increase in qemu_file_fill_buffer() and add asserts to > qemu_file_transferred* functions. > > Signed-off-by: Juan Quintela The read side accounting does look a bit weird and never caught my notice.. Maybe worth also

[PATCH v2 04/20] qemu-file: We only call qemu_file_transferred_* on the sending side

Remove the increase in qemu_file_fill_buffer() and add asserts to qemu_file_transferred* functions. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index