Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper

2020-04-24 Thread Max Reitz
On 24.04.20 16:18, Eric Blake wrote: > On 4/24/20 5:02 AM, Max Reitz wrote: > >>> (With the Patchew warning fixed, of course (i.e., we should set ret to >>> -EPERM or something in qcow.c)) >> >> Er, well, maybe I should have looked into more places.  The compiler >> only warns about that single on

Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper

2020-04-24 Thread Eric Blake
On 4/24/20 5:02 AM, Max Reitz wrote: (With the Patchew warning fixed, of course (i.e., we should set ret to -EPERM or something in qcow.c)) Er, well, maybe I should have looked into more places. The compiler only warns about that single one because it’s the only place where @ret is really uni

Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper

2020-04-24 Thread Stefan Hajnoczi
On Thu, Apr 23, 2020 at 05:17:05PM -0500, Eric Blake wrote: > There are several callers that need to create a new block backend from > an existing BDS; make the task slightly easier with a common helper > routine. > > Suggested-by: Max Reitz > Signed-off-by: Eric Blake > --- > include/sysemu/bl

Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper

2020-04-24 Thread Max Reitz
On 24.04.20 11:56, Max Reitz wrote: > On 24.04.20 11:53, Max Reitz wrote: >> On 24.04.20 00:17, Eric Blake wrote: >>> There are several callers that need to create a new block backend from >>> an existing BDS; make the task slightly easier with a common helper >>> routine. >>> >>> Suggested-by: Max

Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper

2020-04-24 Thread Max Reitz
On 24.04.20 11:53, Max Reitz wrote: > On 24.04.20 00:17, Eric Blake wrote: >> There are several callers that need to create a new block backend from >> an existing BDS; make the task slightly easier with a common helper >> routine. >> >> Suggested-by: Max Reitz >> Signed-off-by: Eric Blake >> ---

Re: [PATCH v2 1/3] block: Add blk_new_with_bs() helper

2020-04-24 Thread Max Reitz
On 24.04.20 00:17, Eric Blake wrote: > There are several callers that need to create a new block backend from > an existing BDS; make the task slightly easier with a common helper > routine. > > Suggested-by: Max Reitz > Signed-off-by: Eric Blake > --- > include/sysemu/block-backend.h | 2 ++ >

[PATCH v2 1/3] block: Add blk_new_with_bs() helper

2020-04-23 Thread Eric Blake
There are several callers that need to create a new block backend from an existing BDS; make the task slightly easier with a common helper routine. Suggested-by: Max Reitz Signed-off-by: Eric Blake --- include/sysemu/block-backend.h | 2 ++ block/block-backend.c | 23 +