Re: [PATCH v2 1/8] block: prepare write threshold code for thread safety

2021-05-06 Thread Vladimir Sementsov-Ogievskiy
06.05.2021 12:04, Stefan Hajnoczi wrote: On Wed, May 05, 2021 at 12:54:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: Hi Stefan! Note my "[PATCH v2 0/9] block: refactor write threshold", it's a kind of counter-proposal for first half of this series. Thanks! Emanuele mentioned he will drop

Re: [PATCH v2 1/8] block: prepare write threshold code for thread safety

2021-05-06 Thread Stefan Hajnoczi
On Wed, May 05, 2021 at 12:54:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi Stefan! > > Note my "[PATCH v2 0/9] block: refactor write threshold", it's a kind of > counter-proposal for first half of this series. Thanks! Emanuele mentioned he will drop his patches. I took a look at your

Re: [PATCH v2 1/8] block: prepare write threshold code for thread safety

2021-05-05 Thread Vladimir Sementsov-Ogievskiy
Hi Stefan! Note my "[PATCH v2 0/9] block: refactor write threshold", it's a kind of counter-proposal for first half of this series. 05.05.2021 11:50, Stefan Hajnoczi wrote: On Mon, Apr 19, 2021 at 10:55:34AM +0200, Emanuele Giuseppe Esposito wrote: No commit description. What about write

Re: [PATCH v2 1/8] block: prepare write threshold code for thread safety

2021-05-05 Thread Stefan Hajnoczi
On Mon, Apr 19, 2021 at 10:55:34AM +0200, Emanuele Giuseppe Esposito wrote: No commit description. What about write thresholds makes them thread unsafe? Without a commit description reviewers have to reverse-engineer the patch to figure out the author's intention, which can lead to

[PATCH v2 1/8] block: prepare write threshold code for thread safety

2021-04-19 Thread Emanuele Giuseppe Esposito
Reviewed-by: Stefan Hajnoczi Co-developed-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- block/write-threshold.c | 28 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/block/write-threshold.c b/block/write-threshold.c index