Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-09-02 Thread Marc-André Lureau
Hi On Fri, Sep 2, 2022 at 3:16 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Thu, Aug 11, 2022 at 5:35 PM Markus Armbruster > wrote: > > > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Aug 11, 2022 at 02:50:01PM +0400, Marc-André Lureau wrote: > >> >> Hi >

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-09-02 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Aug 11, 2022 at 5:35 PM Markus Armbruster wrote: > >> Daniel P. Berrangé writes: >> >> > On Thu, Aug 11, 2022 at 02:50:01PM +0400, Marc-André Lureau wrote: >> >> Hi >> >> >> >> On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell > > >> >> wrote: >> >> [...]

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-22 Thread Marc-André Lureau
Hi On Thu, Aug 11, 2022 at 5:35 PM Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Aug 11, 2022 at 02:50:01PM +0400, Marc-André Lureau wrote: > >> Hi > >> > >> On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell > > >> wrote: > > [...] > > >> > As Markus says, your branch ends

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Aug 11, 2022 at 02:50:01PM +0400, Marc-André Lureau wrote: >> Hi >> >> On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell >> wrote: [...] >> > As Markus says, your branch ends up moving most of qobject into >> > qemu-common/. We are never going to let that out

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Daniel P . Berrangé
On Thu, Aug 11, 2022 at 02:50:01PM +0400, Marc-André Lureau wrote: > Hi > > On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell > wrote: > > > On Thu, 11 Aug 2022 at 11:09, Marc-André Lureau > > wrote: > > > On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster > > wrote: > > >> Your moves tear closely

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Markus Armbruster
Peter Maydell writes: > On Thu, 11 Aug 2022 at 11:09, Marc-André Lureau > wrote: >> On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster wrote: >>> Your moves tear closely related code apart. This is going to be a drag >>> for developers in general and maintainers in particular. >>> >>>

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Marc-André Lureau
Hi On Thu, Aug 11, 2022 at 2:22 PM Peter Maydell wrote: > On Thu, 11 Aug 2022 at 11:09, Marc-André Lureau > wrote: > > On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster > wrote: > >> Your moves tear closely related code apart. This is going to be a drag > >> for developers in general and

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Peter Maydell
On Thu, 11 Aug 2022 at 11:09, Marc-André Lureau wrote: > On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster wrote: >> Your moves tear closely related code apart. This is going to be a drag >> for developers in general and maintainers in particular. >> >> Ergonomics suffer when related code is in

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Marc-André Lureau
On Thu, Aug 11, 2022 at 1:05 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Thu, Aug 11, 2022 at 10:52 AM Markus Armbruster > > wrote: > > > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster > >> wrote: >

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Aug 11, 2022 at 10:52 AM Markus Armbruster > wrote: > >> Marc-André Lureau writes: >> >> > Hi >> > >> > On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster >> wrote: >> > >> >> marcandre.lur...@redhat.com writes: >> >> >> >> > From: Marc-André Lureau

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Marc-André Lureau
Hi On Thu, Aug 11, 2022 at 10:52 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster > wrote: > > > >> marcandre.lur...@redhat.com writes: > >> > >> > From: Marc-André Lureau > >> > > >> > This is just moving qapi-gen.py

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-11 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster wrote: > >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > This is just moving qapi-gen.py and related subdir to qemu-common, to >> > ease review and proceed step by step. The

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-05 Thread Marc-André Lureau
Hi On Fri, Aug 5, 2022 at 12:12 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > This is just moving qapi-gen.py and related subdir to qemu-common, to > > ease review and proceed step by step. The following patches will move > > related

Re: [PATCH v2 11/15] qemu-common: move scripts/qapi

2022-08-05 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > This is just moving qapi-gen.py and related subdir to qemu-common, to > ease review and proceed step by step. The following patches will move > related necessary code, tests etc. > > Signed-off-by: Marc-André Lureau As moved

[PATCH v2 11/15] qemu-common: move scripts/qapi

2022-07-12 Thread marcandre . lureau
From: Marc-André Lureau This is just moving qapi-gen.py and related subdir to qemu-common, to ease review and proceed step by step. The following patches will move related necessary code, tests etc. Signed-off-by: Marc-André Lureau --- docs/conf.py | 2 +-