Re: [PATCH v2 13/16] nvme: factor out namespace setup

2020-04-24 Thread Philippe Mathieu-Daudé
On 4/16/20 8:03 AM, Klaus Birkelund Jensen wrote: On Apr 15 15:26, Philippe Mathieu-Daudé wrote: On 4/15/20 3:20 PM, Klaus Birkelund Jensen wrote: I'll get the v1.3 series ready next. Cool. What really matters (to me) is seeing tests. If we can merge tests (without multiple namespaces) befo

Re: [PATCH v2 13/16] nvme: factor out namespace setup

2020-04-21 Thread Maxim Levitsky
On Wed, 2020-04-15 at 15:01 +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Signed-off-by: Klaus Jensen > --- > hw/block/nvme.c | 46 ++ > 1 file changed, 26 insertions(+), 20 deletions(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > inde

Re: [PATCH v2 13/16] nvme: factor out namespace setup

2020-04-15 Thread Klaus Birkelund Jensen
On Apr 15 15:26, Philippe Mathieu-Daudé wrote: > On 4/15/20 3:20 PM, Klaus Birkelund Jensen wrote: > > > > I'll get the v1.3 series ready next. > > > > Cool. What really matters (to me) is seeing tests. If we can merge tests > (without multiple namespaces) before the rest of your series, even be

Re: [PATCH v2 13/16] nvme: factor out namespace setup

2020-04-15 Thread Philippe Mathieu-Daudé
On 4/15/20 3:20 PM, Klaus Birkelund Jensen wrote: On Apr 15 15:16, Philippe Mathieu-Daudé wrote: On 4/15/20 3:01 PM, Klaus Jensen wrote: From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 46 ++ 1 file changed, 26 insertions(

Re: [PATCH v2 13/16] nvme: factor out namespace setup

2020-04-15 Thread Klaus Birkelund Jensen
On Apr 15 15:16, Philippe Mathieu-Daudé wrote: > On 4/15/20 3:01 PM, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Signed-off-by: Klaus Jensen > > --- > > hw/block/nvme.c | 46 ++ > > 1 file changed, 26 insertions(+), 20 deletions(-) > > > > d

Re: [PATCH v2 13/16] nvme: factor out namespace setup

2020-04-15 Thread Philippe Mathieu-Daudé
On 4/15/20 3:01 PM, Klaus Jensen wrote: From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index d5244102252c..2b007115c302

[PATCH v2 13/16] nvme: factor out namespace setup

2020-04-15 Thread Klaus Jensen
From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 46 ++ 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index d5244102252c..2b007115c302 100644 --- a/hw/block/nvme.c +++ b/hw/block/