Re: [PATCH v2 2/2] hw/nvme: cleanup error reporting in nvme_init_pci()

2022-11-10 Thread Klaus Jensen
On Nov 10 11:00, Markus Armbruster wrote: > Klaus Jensen writes: > > > From: Klaus Jensen > > > > Replace the local Error variable with errp and ERRP_GUARD() and change > > the return value to bool. > > > > Reviewed-by: Markus Armbruster > > Signed-off-by: Klaus Jensen > > --- > > hw/nvme/ctr

Re: [PATCH v2 2/2] hw/nvme: cleanup error reporting in nvme_init_pci()

2022-11-10 Thread Markus Armbruster
Klaus Jensen writes: > From: Klaus Jensen > > Replace the local Error variable with errp and ERRP_GUARD() and change > the return value to bool. > > Reviewed-by: Markus Armbruster > Signed-off-by: Klaus Jensen > --- > hw/nvme/ctrl.c | 23 ++- > 1 file changed, 10 insertion

[PATCH v2 2/2] hw/nvme: cleanup error reporting in nvme_init_pci()

2022-11-09 Thread Klaus Jensen
From: Klaus Jensen Replace the local Error variable with errp and ERRP_GUARD() and change the return value to bool. Reviewed-by: Markus Armbruster Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/hw/nv